1.0 Release and API update #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindgraffiti
approved these changes
Mar 18, 2020
| @@ -69,7 +69,7 @@ extension ViewController: UICollectionViewDataSource { | |||
| func collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) -> UICollectionViewCell { | |||
There was a problem hiding this comment.
On Line 52 of this class, if you add:
stepper.stepValue = value == 18 ? 6 : 12
It will also solve issue #3.
There was a problem hiding this comment.
Thanks :) I think I'll leave this for this PR, but we can always look at solutions in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Gridicons to a 1.0 release number, and updates the API:
Getting an image of a Gridicon is now a case of doing:
let icon = UIImage.gridicon(.pages)With type inference, this can be shortened further:
icon = .gridicon(.pages)You can still optionally specify a size:
let icon = UIImage.gridicon(.pages, size: CGSize(width: 100, height: 100))To test
You can also run and verify the associated WPiOS PR (link coming shortly).