Add P2 icon #58
Merged
Add P2 icon #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ScoutHarris
reviewed
Dec 2, 2020
ScoutHarris
reviewed
Dec 2, 2020
ScoutHarris
approved these changes
Dec 2, 2020
.
Gio2018
approved these changes
Dec 2, 2020
|
Updated to standard podspec versioning (1.1.0-beta.1 instead of 1.0.3-beta.1) and changed target OS version to 11.0 instead of 12.0. Will merge after tests pass. Thank you @Gio2018 and @ScoutHarris for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue: wordpress-mobile/WordPress-iOS#15264
This PR updates the .proj files so it's compatible with Xcode
1211, applies the Xcode recommended project settings updates, adds the P2 icon, and updates the podspec file.To test
rake dependenciesrake gen