Forcibly delete rules cache on flush

[trepmal]

We should ensure that the rewrite rules cache is emptied when flushing the rules

[GaryJones]

Was this fixing a bug? Or just a belt and braces approach to reduce the likelihood of a bug?

[trepmal]

There's a brief history in this Slack thread.

Essentially, there had been several instances where a forced cache delete seemed to be required after flushing the rules. However, that shouldn't be required as the relevant cache should be flushed when the option is changed.

I've also not been aware of this issue recurring in the last several months, so something else may have been at play when this was happening.

[GaryJones]

Thanks for the reference.

Since it's not been happening recently, let's close this out, but it's good to have this as a potential solution if it starts happening again.

[davidsword]

This has been popping up again. If performing a flush, I think it's very reasonable to flush rewrite_rules from the options group as well, given the non-zero chance of rewrite_rules ending up there. A flush should flush everything.