Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move post__not_in sniff to use the grouping in new abstract of WPQueryParamsSniff #594

Closed
rebeccahum opened this issue Oct 26, 2020 · 0 comments · Fixed by #780
Closed

Move post__not_in sniff to use the grouping in new abstract of WPQueryParamsSniff #594

rebeccahum opened this issue Oct 26, 2020 · 0 comments · Fixed by #780
Milestone
3.0.0

Comments

@rebeccahum
Copy link
Contributor

rebeccahum commented Oct 26, 2020 •
edited

We added detection for exclude in #589... but in an attempt to avoid BC-break of error codes, we didn't port over post__not_in to the grouping.
@rebeccahum rebeccahum added this to the 3.x milestone Oct 26, 2020
@jrfnl jrfnl modified the milestones: 4.x, 3.x Aug 21, 2023
@jrfnl jrfnl mentioned this issue Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Performance/WPQueryParams: defer to the parent sniff Automattic/VIP-Coding-Standards
2 participants
@jrfnl @rebeccahum