jrfnl
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
5,361 contributions in the last year
Contribution activity
October 2020
Created a pull request in impress-org/givewp that received 5 comments
Update cs setup
Description Improve the setup to ensure code consistency and PHP cross-version compatibility. Commit Details Composer: fix CS setup This commit doe…
+87
−68
•
5
comments
- CS: remove Yoda conditions
- CS: use combined assignment operators
- CS: rename a local variable to snake_case
- QA: use the most specific PHPUnit assertion possible
- QA: remove useless variable assignments
- Tests: verify exception messages
- CS: don't use assignments in conditions
- CS: don't unnecessarily use double quotes
- CS: use `self` where appropriate
- CS: always have a comma after the last item in a multi-line array
- CS: move test helper classes to their own file
- CS: no multiple assignments in one statement
- QA: use strict comparisons
- CS: align the array assignment operators in multi-line multi-item arrays
- CS: don't use in/decrementors within comparisons
- QA: remove unused code
- QA: don't use count() in a looping condition
- CS: align multiple subsequent assignment statements
- Travis: various fixes
- QA: remove unnecessary references
- New TestVersionTrait
- PHP 8.0 | OptionalToRequiredFunctionParameters: handle crypt $salt becoming required
- PHP 8.0: RequiredToOptionalFunctionParameters - account for more changes
- PHP 8.0: New `PHPCompatibility.Syntax.NewMagicConstantDereferencing` sniff
- PHP 8.0 | New `PHPCompatibility.ParameterValues.ChangedIntToBoolParamType` sniff
- PHP 8.0 | RemovedFunctions: account for more deprecated/removed functions
- PHP 8.0 | RemovedFunctionParameters: account for more deprecated/removed function params
- PHP 8.0 | OptionalToRequiredFunctionParameters: handle required $method / OpenSSL
- PHP 8.0 | NewIniDirectives: allow for new com.dotnet_version directive
- RemovedCallingDestructAfterConstructorExit: reduce false positives
- Docs: add more functions missing from lists
- WP helper functions: stub user_trailingslashit() and wp_json_encode()
- WP: stub the `_n()` and `_nx()` functions
- Docs: add x-links for WP stubs
- WP: stub the `esc_xml()` function
- Docs: add two missing mocked WP functions
- Tests: PHPUnit cross-version compatibility + test against PHP 8
- Composer: update PHPCS Composer plugin dependency
- Various CS/QA fixes (Trac: 50767)
- PHP 8.0: fix "argument # must be passed by reference" warning (Trac: 50913)
- PHP 8.0: fix fatal error "Non-static method cannot be called statically" (Trac: 51559)
- Fix "Only variables should be passed by reference" notice (Trac: 51558)
- Modernize: use explicit visibility for property declarations (Trac 51557)
- Fix mismatched parameter names in child classes (Trac 51553 - task 1)
Created an issue in PHPMailer/PHPMailer that received 1 comment
PHP 8.0: use of deprecated openssl_pkey_free() function
The openssl_pkey_free() function, used in PHPMailer::DKIM_Sign(), is deprecated since PHP 8.0 and may start throwing notices.
It might be a good a …
1
comment
5
contributions
in private repositories
Oct 1 – Oct 21