Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference WordPress.Security.NonceVerification.NoNonceVerification #605

Closed
rebeccahum opened this issue Jan 8, 2021 · 3 comments · Fixed by #607
Closed

Remove reference WordPress.Security.NonceVerification.NoNonceVerification #605

rebeccahum opened this issue Jan 8, 2021 · 3 comments · Fixed by #607
Milestone

Comments

@rebeccahum
Copy link
Contributor

Per the changelog of WPCS 2.0.0-RC1:

The WordPress.Security.NonceVerification sniff used the same error code for both an error as well as a warning. The old error code NoNonceVerification is no longer used. The error now uses the Missing error code, while the warning now uses the Recommended error code. If you are referencing the old error code in a ruleset XML file or in inline annotations, please update these to use the new codes instead.

I think we can remove the reference from the WordPress-VIP-Go ruleset:

<rule ref="WordPress.Security.NonceVerification.NoNonceVerification">

The sniff is still inherited from the parent WordPressVIPMinimum (albeit, different error codes now):

<rule ref="WordPress.Security.NonceVerification"/>

@GaryJones
Copy link
Contributor

Was the NoNonceVerification error code completely removed in WPCS 2.0.0?

@rebeccahum
Copy link
Contributor Author

@jrfnl
Copy link
Collaborator

jrfnl commented Mar 3, 2021

Just for reference - this is the PR/commit which changed the error codes and also explains why the change was made: WordPress/WordPress-Coding-Standards#1487

@jrfnl jrfnl added this to the 2.3.0 milestone Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants