Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BatcacheWhitelistedParamsSniff #613

Closed
rebeccahum opened this issue Jan 11, 2021 · 1 comment · Fixed by #774
Closed

Remove BatcacheWhitelistedParamsSniff #613

rebeccahum opened this issue Jan 11, 2021 · 1 comment · Fixed by #774
Labels
Require: VIPCS 3.0 Breaking changes for major version Status: Has PR
Milestone

Comments

@rebeccahum
Copy link
Contributor

Same reason as #612 — no longer needed since WordPress.com sites are migrated.

@jrfnl
Copy link
Collaborator

jrfnl commented Mar 2, 2021

Same as for #612:

Action plan suggestion:

  1. Deprecate the sniff in the next release (2.x) by:
    1. Adding a deprecation warning to the sniff which will inform people to remove the sniff reference from their own custom ruleset.
    2. Silencing all messages from the sniff from within the VIPMinimum ruleset, effectively removing the sniff already for people using the standard rulesets.
  2. Remove the actual sniff in the next major, i.e. 3.0.0.

Loosely related to #600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Require: VIPCS 3.0 Breaking changes for major version Status: Has PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants