Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Invalid file type" error not shown in ajax upload. #2233

Closed
3 tasks done
aaronfc opened this issue Apr 28, 2022 · 1 comment · Fixed by #2678
Closed
3 tasks done

"Invalid file type" error not shown in ajax upload. #2233

aaronfc opened this issue Apr 28, 2022 · 1 comment · Fixed by #2678

Comments

@aaronfc
Copy link
Contributor

aaronfc commented Apr 28, 2022

Describe the bug
When a file with an invalid type is selected in a file input while ajax upload is enabled the file is ignored but no feedback is shown to the user.

To Reproduce
Steps to reproduce the behavior:

  1. Go to submit a job.
  2. Select an incorrect file (anything which is not an image) when uploading the company logo.

Screenshots
Kapture 2022-04-28 at 10 23 41

Expected behavior
Some feedback should be shown to the user. Other similar errors like when a file is too big are displayed with a simple window.alert.

Isolating the problem (mark completed items with an [x]):

  • I have deactivated other plugins and confirmed this bug occurs when only WP Job Manager plugin is active.
  • This bug happens with a default WordPress theme active.
  • I can reproduce this bug consistently using the steps above.

WordPress Environment

  • WordPress Version: 5.9.1
  • WP Job Manager Version: 0486584
  • PHP Version: 7.4.1
  • Other important details: We have a tutorial explaining how to limit the file types allowed during upload here.
@Hastibe
Copy link

Hastibe commented Jun 23, 2022

Thanks for creating this bug report, @aaronfc -- we've noticed this, too, and have had users confused by it, so having an error thrown for the user when they attempt to add an invalid file type as the logo would be helpful.

@mikeyarce mikeyarce self-assigned this Dec 11, 2023
@mikeyarce mikeyarce changed the title "Invalid file type" error now shown in ajax upload. "Invalid file type" error not shown in ajax upload. Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants