prioritize redirect from_url validation to avoid duplicates #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Currently a numeric redirect destination (based on post ID) is handled by validate_urls() before it is checked as an existing URL. The return occurs prior to the duplicate check running. - This fix prioritizes to make sure we check for possible duplicates first.
GaryJones
approved these changes
May 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Currently a numeric redirect destination (based on post ID) is handled by validate_urls() before it is checked as an existing redirect $from_url. The return occurs prior to the duplicate check running.
Fix: This prioritizes validation rules to ensure we always check for possible duplicates first. Previously the array was returned if a post ID was provided before this check. Now it will display "Error: A redirect for this URI already exists" as expected.
OK (8 tests, 16 assertions). Also tested successfully based on the issue outlined by @GaryJones
@rebeccahum Issue #53