Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woocommerce compatibility #1257

Closed
thetwentyseven opened this issue Feb 1, 2018 · 5 comments
Closed

Woocommerce compatibility #1257

thetwentyseven opened this issue Feb 1, 2018 · 5 comments

Comments

@thetwentyseven
Copy link

In the last version of Woocommerce at least, the WC templates did not load. I thought it was my edited version of Undersocores but I just download a new Undersores Theme and without changing anything the problem persist.

I tried with few other themes and they work properly. For instance, with the theme Twenty Fourteen, we can see that the Query Monitor, inside the page Shop, can detect that the Template loaded is "/plugins/woocommerce/templates/archive-product.php" whereas in Underscore is "page.php".

@thetwentyseven
Copy link
Author

thetwentyseven commented Feb 1, 2018

I can confirm that the Woocommerce version 3.2.6 that was the previous stable version works with the current version of Underscores.

In order to download previous version you can go to this link: https://github.com/woocommerce/woocommerce/releases

@WPprodigy
Copy link

@thetwentyseven - in order to override templates now, you need to declare WC theme support: https://github.com/woocommerce/woocommerce/wiki/Declaring-WooCommerce-support-in-themes

Underscores looks like it does this for you if you choose the WooCommerce advanced option when downloading from the website: https://github.com/Automattic/_s/blob/master/inc/woocommerce.php#L19


As for WC 3.3.+, the theme/inc/woocommerce.php file could use some compatibility updates.

Namely should remove loop_shop_columns and loop_shop_per_page filters and use new theme support options for those.

@thetwentyseven
Copy link
Author

I see know the option "WooCommerce boilerplate". Thank you very much!

@jeffikus
Copy link
Contributor

jeffikus commented Feb 8, 2018

There is also an open issue for the customizer update #1259 that I'm working on.

@samikeijonen
Copy link
Contributor

@WPprodigy Can you open new issue/PR what would need to change in _s to meet new Woocommerce setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants