Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$content_width definition inside _s_setup? #480

Closed
mor10 opened this issue May 4, 2014 · 1 comment
Closed

$content_width definition inside _s_setup? #480

mor10 opened this issue May 4, 2014 · 1 comment

Comments

@mor10
Copy link
Contributor

mor10 commented May 4, 2014

During the submission of a theme to the directory I was instructed that placing the definition of $content_width outside the theme setup function was a blocker. If that is the case I would recommend the definition be moved into _s_setup to avoid unnecessary tickets during theme submission. If on the other hand this is incorrect I would recommend providing this information to the theme reviewers as they are flagging it as an issue.
@ScottSmith95
Copy link
Contributor

Duplicate of #460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@philiparthurmoore @ethitter @ScottSmith95 @mor10