Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ID to comment labels for post #898

Closed
wants to merge 1 commit into from
Closed

Adding ID to comment labels for post #898

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 7, 2016

Each comment will reflect the post’s unique ID for better
identification.

Each comment will reflect the post’s unique ID for better
identification.
@karmatosed
Copy link
Contributor

What is the benefit of doing this?

@ghost
Copy link
Author

ghost commented Feb 10, 2016

The only difference is you get to identify which post the comment belongs to. For example, instead of <!-- #post-## -->, you'll get <!-- #post-123 -->.

It's a minor change, but I had times where I was looking at the console and had to scroll up to read which post it belonged to.

@sixhours
Copy link
Contributor

This makes sense to me.

@ghost
Copy link
Author

ghost commented Apr 18, 2016

@karmatosed Any thoughts?

@philiparthurmoore
Copy link
Collaborator

Looks like a great change. Travis errors need to be resolved but the change has solid reasoning behind it.

@karmatosed
Copy link
Contributor

Thanks for your explanation @ghost. I think lets have a refreshed PR and we can take a look.

@grappler
Copy link
Collaborator

@karmatosed @ghost Is a deleted account. You won't get any response. We will need to close the PR and create a new one.

@karmatosed
Copy link
Contributor

Thanks for catching that @grappler

@davidakennedy
Copy link
Contributor

Closing this out as this was done in #1106.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants