Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max-width to select elements in widgets to prevent it overflowing from widget areas. #99

Merged
merged 1 commit into from
Jan 5, 2013
Merged

Add max-width to select elements in widgets to prevent it overflowing from widget areas. #99

merged 1 commit into from
Jan 5, 2013

Conversation

iamtakashi
Copy link
Contributor

I find myself adding this frequently and I thought it could be useful to have in _s.

This intends to fix a common issue - the dropdown in the category widget overflows when a blog has a long category name.

…ng. This intends to fix a common issue - the dropdown in the category widget overflows when a blog has a long category name
@mfields
Copy link
Contributor

mfields commented Nov 10, 2012

This seems like a really good idea to me. A lot of themes will set overflow: hidden; on the sidebar to keep longer items from "breaking out" of it. Select elements containing longer item names will naturally break out of small width containers meaning that they can be hidden. This fixes that! I suggest merge.

@mfields
Copy link
Contributor

mfields commented Nov 20, 2012

This just came up today while I was coding. @iamtakashi what do you think about adding a test case for this to the monster widget too? This way we can be sure to always see that there is a possibility of this kind of thing happening?

@iamtakashi
Copy link
Contributor Author

@mfields, Yes that's also good idea too because many themers might not have realised this happens quite frequently in the real world. (Put aside the argument, whether having a long category name is good or bad)

And _s will take care of the issue with my suggestion. Win. If there is no strong opinion form anybody, we should merge this.

mfields pushed a commit that referenced this pull request Jan 5, 2013
Add max-width to select elements in widgets to prevent it overflowing from widget areas. props @iamtakash
@mfields mfields merged commit 80d803a into Automattic:master Jan 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants