Skip to content

Commit

Permalink
Fix Strict 'pass by reference' warning by not calling array_shift() o…
Browse files Browse the repository at this point in the history
…n the direct result of array_shift()

Strict Standards: Only variables should be passed by reference in
path/ad-code-manager/ad-code-manager.php on line 1003
  • Loading branch information
nickdaugherty committed Jan 22, 2014
1 parent 746f97e commit cec42cd
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion ad-code-manager.php
Expand Up @@ -1000,7 +1000,10 @@ public function get_matching_ad_code( $tag_id ) {
$prioritized_display_codes[$priority][] = $display_code;
}
ksort( $prioritized_display_codes, SORT_NUMERIC );
$code_to_display = array_shift( array_shift( $prioritized_display_codes ) );

$shifted_prioritized_display_codes = array_shift( $prioritized_display_codes );

$code_to_display = array_shift( $shifted_prioritized_display_codes );

wp_cache_add( $cache_key, $code_to_display, 'acm', 600 );

Expand Down

0 comments on commit cec42cd

Please sign in to comment.