Implement Dropdown Facet filters

[postphotos]

As an developer using the AMP for WordPress plugin, I should have a way to filter errors on each index listing screen (by URL and by Error).

Formal AC to come.

[westonruter]

Filtering by error I understand to mean showing a list of URLs that have a given error. This is currently possible by clicking on the URL count in each validation error row.

For filtering by URL, what does this mean? Is this not the invalid URL list view?

[kienstra]

Filtering On 'Errors By URL' Page

Based on our discussion this morning, it looks like there aren't filters anymore on the 'Errors by URL' page (previously called 'Invalid Pages').

PR #1373 now allows filtering the 'Errors by URL' page (previously called 'AMP Validation Errors') by accepted status and error type.

[westonruter]

Based on our discussion this morning, it looks like there aren't filters anymore on the 'Errors by URL' page (previously called 'Invalid Pages').

Humm, I think this isn't right. There are currently filters in the plugin for selecting invalid URLs that have errors with a given status. There is also a filter for the date and search:

I don't think these should go away.

But on this invalid URLs screen (errors by URL) should there be a new dropdown for selecting URLs that have errors of a given type? Note that in addition to storing the error attributes in the term description, the full error JSON is also stored in the post_content for an amp_invalid_url post; so a regular search could be done to find such errors here, without having to worry about doing a join on the description field for amp_validation_error terms.

But should the status links get converted into a dropdown?

[kienstra]

Add Filter Dropdowns

Hi @westonruter,
Based on our meeting, there will be 2 filter <select> elements added to this 'Errors by URL page.

This page should have the same 'All Statuses' and 'All Error Types' dropdowns that exist on the 'Errors by Type' page (in addition to the existing date filter):

Also, I requested that the design be updated.

[westonruter]

Fixed by #1373.

[kienstra]

'Moving to 'Ready For Merging'

If it's alright, I'm moving this to 'Ready For Merging,' as the filters should be tested in #1361 and #1362.