New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Jetpack helper and some parts of WPCOM helper #1149

Merged
merged 3 commits into from May 18, 2018

Conversation

Projects
None yet
3 participants
@gravityrail
Contributor

gravityrail commented May 15, 2018

Fixes #1021

Removes the Jetpack helper after Jetpack version 6.2. Also moves some wpcom-helper functions over to Jetpack, where appropriate.

Once Automattic/jetpack#9458 is merged, this can be merged too, as AMP support will be explicitly included in Jetpack.

@westonruter

This comment has been minimized.

Show comment
Hide comment
@westonruter

westonruter May 15, 2018

Collaborator

This is part of #1021

Collaborator

westonruter commented May 15, 2018

This is part of #1021

@gravityrail gravityrail changed the title from Deprecate Jetpack helper to Deprecate Jetpack helper and some parts of WPCOM helper May 15, 2018

@gravityrail gravityrail requested a review from philipjohn May 15, 2018

@gravityrail gravityrail self-assigned this May 15, 2018

@ebinnion

I left a few minor comments on your Jetpack PR, but things seemed to test well.

@westonruter westonruter added this to the v1.0 milestone May 18, 2018

@westonruter westonruter merged commit 927b07c into develop May 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the try/deprecate-jetpack-helper branch May 18, 2018

@westonruter

This comment has been minimized.

Show comment
Hide comment
@westonruter

westonruter May 18, 2018

Collaborator

@gravityrail I just realized that we may have a timing issue with this PR and Jetpack. If AMP 1.0 is released after Jetpack 6.2, is that going to cause a problem? If so, we may want to merge these commits into the 0.7 branch to ensure that it is released before Jetpack.

Collaborator

westonruter commented May 18, 2018

@gravityrail I just realized that we may have a timing issue with this PR and Jetpack. If AMP 1.0 is released after Jetpack 6.2, is that going to cause a problem? If so, we may want to merge these commits into the 0.7 branch to ensure that it is released before Jetpack.

@westonruter westonruter modified the milestones: v1.0, v0.7.1 May 23, 2018

@westonruter

This comment has been minimized.

Show comment
Hide comment
@westonruter

westonruter May 23, 2018

Collaborator

I've cherry-picked the commits in this branch to 0.7.1: #1170

Collaborator

westonruter commented May 23, 2018

I've cherry-picked the commits in this branch to 0.7.1: #1170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment