-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for extracting (pixel) dimensions from SVG images #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b105a25
to
795d88e
Compare
f12ef62
to
e4c073b
Compare
e4c073b
to
4ef7950
Compare
amedina
reviewed
May 17, 2018
@@ -70,7 +70,14 @@ public function getType() | |||
case chr(0x89).'P': | |||
return $this->type = 'png'; | |||
default: | |||
return false; | |||
$this->strpos = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a clarifying question: why can't the SVG part be on its own 'case' branch rather than on the 'default' one?
amedina
approved these changes
May 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty good; ship it!
This was referenced Jan 11, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are
img
tags that reference SVG images and theimg
does not include thewidth
orheight
in HTML, we need to obtain the dimensions of the underlying SVG image in its ownwidth
andheight
attributes in a similar way to how we extract dimensions from raster image formats like PNG and JPEG.viewBox
ifwidth
orheight
attributes aren't pixel values.