Add support for extracting (pixel) dimensions from SVG images #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
changed the title
westonruter
force-pushed
the
add/svg-image-dimension-extraction
branch
21 times, most recently
from
b105a25
to
795d88e
Compare
westonruter
force-pushed
the
add/svg-image-dimension-extraction
branch
4 times, most recently
from
f12ef62
to
e4c073b
Compare
westonruter
force-pushed
the
add/svg-image-dimension-extraction
branch
from
e4c073b
to
4ef7950
Compare
westonruter
changed the title
amedina
reviewed
May 17, 2018
| @@ -70,7 +70,14 @@ public function getType() | |||
| case chr(0x89).'P': | |||
| return $this->type = 'png'; | |||
| default: | |||
| return false; | |||
| $this->strpos = 0; | |||
There was a problem hiding this comment.
Just a clarifying question: why can't the SVG part be on its own 'case' branch rather than on the 'default' one?
amedina
approved these changes
May 17, 2018
This was referenced Jan 11, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are
imgtags that reference SVG images and theimgdoes not include thewidthorheightin HTML, we need to obtain the dimensions of the underlying SVG image in its ownwidthandheightattributes in a similar way to how we extract dimensions from raster image formats like PNG and JPEG.viewBoxifwidthorheightattributes aren't pixel values.