Add page support #825

ThierryA · 2017-12-07T20:04:52Z

This PR adds support for pages, refer to the ACs for more info...

Fixes #176.
Closes #188.
Closes #816.
Closes #619.

Inspired by #188 & #816
Kudos to @technosailor, @mjangda and @mpszone for their contribution.

…draft and previews) * Use query var in permalinks containing query vars, instead of endpoint slug. * Remove needless and unslightly 1 value. * Add tests.

westonruter · 2017-12-08T01:15:11Z

includes/class-amp-post-template.php

-				'name' => $this->get( 'blog_name' ),
-			),
-			'headline' => $post_title,
-			'datePublished' => date( 'c', $post_publish_timestamp ),


These Schema.org properties are also relevant to WebPage entities: http://schema.org/WebPage

So I don't see why we need to limit them just to posts.

@westonruter I would argue that. This really depends on the use cases but in most cases pages published/modified date are not relevant, or even inconvenient. It is a very common use case not to include the datePublished and datePublished. If we take Apple for example, we can see that datePublished is used on news article but not on pages.

True, but this is just in regards to the template rendering of the data. We're talking about metadata here. It should be up to the application to decide whether or not to show the datePublished if the type is WebPage. In other words, the WP REST API for pages includes the published date, and that I think is a better parallel to the Schema.org metadata here.

Sounds good, I am on board 😄

…rotected or skipped

… (for now)

westonruter · 2017-12-08T02:09:15Z

templates/footer.php

 		</p>
 		<a href="#top" class="back-to-top"><?php esc_html_e( 'Back to top', 'amp' ); ?></a>
 	</div>
 </footer>
+
+<?php do_action( 'amp_post_template_footer', $this ); ?>


Putting this inside of footer will be problematic for any themes that have their own existing footer.php override.

Great thoughts!

…template parts

westonruter · 2017-12-08T04:36:57Z

Merging this is dependent on @amedina confirming with the Google search team that we can reliably use amp query parameters. We may need to add a rel=canonical link.

ThierryA

Thanks @weston, here is the CR and enhancement.

ThierryA · 2017-12-08T09:10:28Z

includes/class-amp-post-template.php

-				'name' => $this->get( 'blog_name' ),
-			),
-			'headline' => $post_title,
-			'datePublished' => date( 'c', $post_publish_timestamp ),


@westonruter I would argue that. This really depends on the use cases but in most cases pages published/modified date are not relevant, or even inconvenient. It is a very common use case not to include the datePublished and datePublished. If we take Apple for example, we can see that datePublished is used on news article but not on pages.

ThierryA · 2017-12-08T09:27:10Z

templates/admin/amp-status.php

-		<div class="amp-status-actions">
-			<a href="#amp_status" class="save-amp-status hide-if-no-js button"><?php esc_html_e( 'OK', 'amp' ); ?></a>
-			<a href="#amp_status" class="cancel-amp-status hide-if-no-js button-cancel"><?php esc_html_e( 'Cancel', 'amp' ); ?></a>
+	<?php if ( $available ) : ?>


I really like that approach, in fact I think we could apply the same for CPT with support disabled. That said, I think it isn't really clear for the user as why it is disabled and why the ability to edit the status is removed. I would suggest to keep the edit link and display a warning when toggled (no visual noise on load, informative on toggle)? Here is a commit which implements it, the warning may be more target if need be and if time allows.

westonruter · 2017-12-08T17:55:25Z

templates/admin/amp-status.php

+			</fieldset>
+		<?php else : ?>
+			<div class="inline notice notice-warning">
+				<p><?php esc_html_e( 'AMP cannot be enabled on home page, front page, password protected posts and post types which do not support AMP.', 'amp' ); ?></p>


I think this message should only be shown if the post is the homepage, page for posts, password protected posts, or posts that don't support AMP. In other cases, we should show a different message such as when a plugin blocks AMP for a post via the amp_skip_post filter. For example:

A plugin or theme has disabled AMP support.

Also, the translation string should be changed to replace “front page” with “page for posts”. You can also use “homepage” instead of having a space in there.

Per core:

Also probably should say that AMP cannot yet be enabled for those certain pages. Our intention is to eventually allow every page to be AMPed.

Thanks for your feedback @westonruter. I improved the error messages to be more accurate in this commit. I had to add amp_post_supports_error() function to avoid redoing all checks.

amedina

Looks pretty good to me. Do tests pass all the AC?

ThierryA · 2017-12-08T19:26:13Z

Thanks @amedina, yes all AC are covered in this PR and we should be pretty close to merging and sending this to QA (once this commit is reviewed).

…pport_errors()

…ability are exhausted

westonruter · 2017-12-08T21:24:34Z

@ThierryA I did a bit more refactoring on the latest changes. Since there can be multiple reasons for why a post does not support AMP:

@amedina Ready for your ✅

ThierryA · 2017-12-08T22:06:25Z

Great @weston, all latest changes are good to go codewise from my perspective.

westonruter · 2017-12-09T00:22:32Z

Some screenshots:

176: add page support

6b4de15

ThierryA requested a review from westonruter December 7, 2017 20:04

westonruter added 2 commits December 7, 2017 16:27

Fix amp_get_permalink() for permalinks containing query params (e.g. …

c5231b0

…draft and previews) * Use query var in permalinks containing query vars, instead of endpoint slug. * Remove needless and unslightly 1 value. * Add tests.

Always use amp query var in permalinks for hierarchical post types

dcf7eb1

westonruter mentioned this pull request Dec 8, 2017

Add support for using regular WordPress theme templates in AMP, in paired or canonical modes #827

Closed

westonruter reviewed Dec 8, 2017

View reviewed changes

westonruter added 3 commits December 7, 2017 17:29

Restore Schema.org properties for WebPage entity

3a76316

Show AMP as disabled without UI to make enabled if post is password p…

2ae58d2

…rotected or skipped

Return false from post_supports_amp() for homepage and page for posts…

e7221f4

… (for now)

westonruter mentioned this pull request Dec 8, 2017

Move AMP initialization logic into after_setup_theme, conditioned on amp_is_enabled filter #826

Merged

Update readme

51c5b17

westonruter reviewed Dec 8, 2017

View reviewed changes

westonruter changed the title ~~[WIP] #176: add page support~~ Add page support Dec 8, 2017

westonruter approved these changes Dec 8, 2017

View reviewed changes

westonruter mentioned this pull request Dec 8, 2017

Support for Pages #176

Closed

Refactor header/footer template parts to extract html-start/html-end …

5dd2bc6

…template parts

westonruter force-pushed the feature/176-page-support branch from ff8b532 to 5dd2bc6 Compare December 8, 2017 03:30

westonruter requested a review from amedina December 8, 2017 04:36

Always display AMP status + notice where applicable

57f5849

ThierryA commented Dec 8, 2017

View reviewed changes

westonruter reviewed Dec 8, 2017

View reviewed changes

Improve post status notice

269b937

amedina reviewed Dec 8, 2017

View reviewed changes

westonruter added 3 commits December 8, 2017 12:37

Include link to AMP post type settings screen in notice; use alt style

cff791e

Refactor amp_post_supports_error() into AMP_Post_Type_Support::get_su…

9630709

…pport_errors()

Include fallback error message for when all known reasons for unavail…

34a0e9e

…ability are exhausted

westonruter merged commit edd7a40 into develop Dec 8, 2017

westonruter deleted the feature/176-page-support branch December 8, 2017 22:11

westonruter added this to the v0.6 milestone Dec 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add page support #825

Add page support #825

ThierryA commented Dec 7, 2017 •

edited

Loading

westonruter Dec 8, 2017

ThierryA Dec 8, 2017 •

edited

Loading

westonruter Dec 8, 2017

ThierryA Dec 8, 2017 •

edited

Loading

westonruter Dec 8, 2017

ThierryA Dec 8, 2017

westonruter commented Dec 8, 2017

ThierryA left a comment

ThierryA Dec 8, 2017 •

edited

Loading

ThierryA Dec 8, 2017

westonruter Dec 8, 2017

westonruter Dec 8, 2017

westonruter Dec 8, 2017

ThierryA Dec 8, 2017

amedina left a comment

ThierryA commented Dec 8, 2017

westonruter commented Dec 8, 2017

ThierryA commented Dec 8, 2017

westonruter commented Dec 9, 2017

Add page support #825

Add page support #825

Conversation

ThierryA commented Dec 7, 2017 • edited Loading

Choose a reason for hiding this comment

ThierryA Dec 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ThierryA Dec 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

westonruter commented Dec 8, 2017

ThierryA left a comment

Choose a reason for hiding this comment

ThierryA Dec 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amedina left a comment

Choose a reason for hiding this comment

ThierryA commented Dec 8, 2017

westonruter commented Dec 8, 2017

ThierryA commented Dec 8, 2017

westonruter commented Dec 9, 2017

ThierryA commented Dec 7, 2017 •

edited

Loading

ThierryA Dec 8, 2017 •

edited

Loading

ThierryA Dec 8, 2017 •

edited

Loading

ThierryA Dec 8, 2017 •

edited

Loading