Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect amp_css_bad_file_extension prior to looking at filesystem #890

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Detect amp_css_bad_file_extension prior to looking at filesystem #890

merged 1 commit into from
Jan 26, 2018

Conversation

westonruter
Copy link
Member

Amends #887

@westonruter westonruter added this to the v0.7 milestone Jan 23, 2018
ThierryA
ThierryA approved these changes Jan 26, 2018
View reviewed changes
Copy link
Collaborator

@ThierryA ThierryA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is good to go, however it seems like there is an issue with the error being displayed twice. Actually an error with the theme index.php being called twice. Weston do you also experiment that?

@ThierryA ThierryA merged commit f877050 into develop Jan 26, 2018
@westonruter westonruter deleted the fix/get_validated_css_file_path branch February 3, 2018 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThierryA ThierryA ThierryA approved these changes

Assignees

@ThierryA ThierryA

Labels
None yet
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@westonruter @ThierryA