-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
antiscroll does not work with chrome Version 25.0.1323.1 dev #40
Conversation
Antiscroll stopped working properly in Chrome v25 (it's still in dev channel). For some reason native scrollbars are displayed under the antiscroll generated scrollbars. The browser behaves as if ::scrollbar pseudo class styles (setting scrollbar width/height to 0) were ignored. I am not really sure what's causing that, but when trying to investigate the problem I realized that scrollbarSize did not work properly in Chrome. It was returning 0 and not the native scrollbar width. We now calculate the size in the container with 'antiscroll-inner' class applied. If ::scrollbar CSS is applied properly the width is 0, and we don't have to hide native scrollbars manually. Otherwise scrollbars are hidden by adjusting .antiscroll-inner size. That fixes Chrome v25 issue.
Chrome 25 just went live, and this issue is still present. |
@pirxpilot commit fixed the problem. Tested it cross browser and it's good. Can we get this merged? |
Thanks @pirxpilot, I'm now using your branch until this gets fixed ;). Ping @LearnBoost |
I just checked and it still merges cleanly. In the meantime, if you need all the latest and greatest antiscroll and fix for #40 just use pu-chrome-25 branch. |
@pirxpilot tx |
antiscroll does not work with chrome Version 25.0.1323.1 dev
Thanks so much guise |
tx :D |
I put my this in my css to fix the problem, instead of changing the js. /Fix to Chrome v25 scrollbar problems./ |
The problem still persists in Chrome 25 on Lion. |
Thanks @epitrochoider that did the trick! It might be a better idea to have it in the library css file though. This is what I added to antiscroll.css : .antiscroll-wrap ::-webkit-scrollbar { |
@davemckenna01 do you have a PR with the changes? |
@internalsystemerror indeed I do! #47 |
I've tested on windows chrome and all's still fine :). |
Great :) Thanks - this was a weird one - I should let the chrome devs know about this. Something must be wrong with how they're parsing css under the hood. |
Antiscroll stopped working properly in Chrome v25 (it's still in dev channel). For some reason native scrollbars are displayed under the antiscroll generated scrollbars. The browser behaves as if ::scrollbar pseudo class styles (setting scrollbar width/height to 0) were ignored.
I am not really sure what's causing that, but when trying to investigate the problem I realized that scrollbarSize did not work properly in Chrome. It was returning 0 and not the native scrollbar width.
We now calculate the size in the container with 'antiscroll-inner' classapplied. If ::scrollbar CSS is applied properly the width is 0, and we don't have to hide native scrollbars manually. Otherwise scrollbars are hidden by adjusting .antiscroll-inner size.
That fixes Chrome v25 issue.