Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset the position of the toolbar for compat with Gutenberg 15.7+ #183

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

ryelle
Copy link
Member

@ryelle ryelle commented Jun 15, 2023

See #176

This switches the toolbar to be static-positioned on wp.org, so that it shows up above the post editor rather than floating outside it. It does remove the "fixed" aspect, if you write a long topic, the toolbar scrolls off screen.

This is really just a workaround for wordpress.org, so that we can unpin the version of Gutenberg — it doesn't do anything to fix the issue anywhere else the editor is used. This could be ported as a quick fix for other editors, or (more likely) it needs a better solution. So feel free to take or leave this PR 🙂

Before After
Screenshot 2023-06-15 at 2 00 45 PM Screenshot 2023-06-15 at 1 55 26 PM

@ryelle ryelle self-assigned this Jun 15, 2023
@johngodley
Copy link
Member

Thanks! Yeah, I've been sitting on a similar change for a while and was hoping to come up with something better, but fundamentally a change will be needed in Gutenberg to support it.

I've put a similar change in Automattic/isolated-block-editor#230 and this will be included with #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants