Fixes cascading from _shared.json when target configuration file has features defined
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s" when running tests See jestjs/jest#6766
brunobasto
force-pushed
the
fix/shared-file-inheritance
branch
from
67100d6
to
20f4be2
Compare
mjangda
approved these changes
Oct 14, 2021
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cascading of features would only work if target configuration file didn't have a
featuresfield defined. This wasn't ideal If we wanted to inherit some configurations from_shared.jsonand override some or add some more.Also fixed Jest tests and added a
package-lock.jsonsince this repo didn't have one.