Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying the height unit #137

Closed
2 tasks
psrpinto opened this issue Nov 23, 2022 · 0 comments · Fixed by #154
Closed
2 tasks

Allow specifying the height unit #137

psrpinto opened this issue Nov 23, 2022 · 0 comments · Fixed by #154
Assignees
@psrpinto
Milestone
0.5

Comments

@psrpinto
Copy link
Member

psrpinto commented Nov 23, 2022 •
edited

Currently it's hardcoded to pixels.

Ideally, we should use this component (present in the Group block):

Screenshot 2022-11-23 at 16 39 26

  • Introduce HeightInput component for inspector controls
  • Pass height and heightUnit to IFrame instead of heightWithUnit
@psrpinto psrpinto added this to the 0.4.0 - Beta milestone Nov 23, 2022
@psrpinto psrpinto mentioned this issue Nov 23, 2022
Merged
@psrpinto psrpinto self-assigned this Nov 23, 2022
@psrpinto psrpinto modified the milestones: 0.4, 0.5 Dec 2, 2022
@psrpinto psrpinto removed their assignment Dec 2, 2022
@psrpinto psrpinto self-assigned this Jan 5, 2023
@psrpinto psrpinto mentioned this issue Jan 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psrpinto psrpinto

Labels
None yet
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

Height unit selector Automattic/chatrix
1 participant
@psrpinto