Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height unit selector #154

Merged
merged 7 commits into from Jan 25, 2023
Merged

Height unit selector #154

merged 7 commits into from Jan 25, 2023

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Jan 10, 2023

Fixes #137

This PR makes it possible to change the unit of fields, as opposed to the unit being hardcoded to px.

Screen capture

Screenshot 2023-01-11 at 15 28 34

@psrpinto psrpinto self-assigned this Jan 10, 2023
@psrpinto
Copy link
Member Author

This is mostly done, but there's an issue where the Resizable box does not correctly follow the height of the block, when certain styling changes its height (e.g. border-width). I'm working on addressing this issue.

Screenshot 2023-01-11 at 15 05 32

@psrpinto
Copy link
Member Author

The issue mentioned above is also present on the main branch so it's not introduced by this PR. I've opened #162 to track it so that this PR can move forward.

@psrpinto psrpinto marked this pull request as ready for review January 24, 2023 14:33
@psrpinto psrpinto requested a review from ashfame January 24, 2023 14:33
@psrpinto psrpinto merged commit 4022c30 into main Jan 25, 2023
@psrpinto psrpinto deleted the height-unit branch January 25, 2023 13:00
@psrpinto psrpinto mentioned this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying the height unit
2 participants