Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple Chatrix blocks on the same page or on different browser tabs #214

Merged
merged 9 commits into from
Apr 14, 2023

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Apr 11, 2023

This PR brings in the changes from hydrogen related to "same session in multiple tabs" feature. The feature flag needs to be manually enabled through Settings, for now.

Enable feature flag

  1. Open a session
  2. Click the Settings gear icon (or three-dot menu and then Settings, when in single-room mode)
  3. Scroll down to Experimental Features
  4. Enable the Open the same session in multiple tabs feature flag

Screenshot 2023-04-17 at 13 36 30

@psrpinto psrpinto self-assigned this Apr 11, 2023
@akirk akirk changed the title Open the same session in multiple tabs Allow multiple Chatrix blocks on the same page or on different browser tabs Apr 12, 2023
@psrpinto psrpinto force-pushed the same-session-in-multiple-tabs branch 2 times, most recently from 4252003 to 3402210 Compare April 14, 2023 10:09
@psrpinto psrpinto marked this pull request as ready for review April 14, 2023 10:11
@psrpinto psrpinto requested a review from ashfame April 14, 2023 10:11
Copy link
Member

@ashfame ashfame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I am unclear on how to enable the feature flag though. I imagine, we would enable the feature flag for chatrix build and we would have it functional without making any changes in the settings. What am I missing?

yarn.lock Outdated Show resolved Hide resolved
@psrpinto
Copy link
Member Author

psrpinto commented Apr 14, 2023

I am unclear on how to enable the feature flag though

The idea was that, for now, the user needs to go into Hydrogen's settings and enable the feature flag, since some things are broken, for example logout, and encrypted rooms, etc. Once we've address (some of?) these issues we can issue a new release with the feature flag enabled by default. Does that make sense?

@psrpinto psrpinto merged commit 689c324 into main Apr 14, 2023
@psrpinto psrpinto deleted the same-session-in-multiple-tabs branch April 14, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants