Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop engines requirement #23

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Drop engines requirement #23

merged 1 commit into from
Jan 29, 2020

Conversation

blowery
Copy link
Contributor

@blowery blowery commented Jan 29, 2020

Since this is a library and usage doesn't require node 10, drop the engines statement. This allows folks using node@12 and yarn to install the package.

Since this is a library and usage doesn't require node 10, drop the engines statement. This allows folks using node@12 and yarn to install the package.
@blowery blowery self-assigned this Jan 29, 2020
@blowery blowery mentioned this pull request Jan 29, 2020
14 tasks
Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@porada porada merged commit 01c7808 into master Jan 29, 2020
@porada
Copy link
Member

porada commented Jan 29, 2020

Thanks for the suggestion. I just published @automattic/color-studio@2.2.1 with the fix.

@blowery
Copy link
Contributor Author

blowery commented Jan 29, 2020

Thanks @porada and @simison!

@blowery blowery deleted the drop-engines branch January 29, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants