socket: allow upgrades if the socket is still in closing state (courtesy of @3rd-Eden) #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchg
added a commit
that referenced
this pull request
Oct 3, 2014
socket: allow upgrades if the socket is still in closing state (courtesy of @3rd-Eden)
darrachequesne
pushed a commit
that referenced
this pull request
May 8, 2020
polling-xhr: fix a comment and remove unneeded `document` reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that any buffered data still to be flushed, can be sent to the client.
After flushing the data, if the
readyStatewas set to'closing', this will close the newly created transport and the connection.