Skip to content

Commit

Permalink
Merge pull request #184 from Automattic/improve/promise-no-multiple-r…
Browse files Browse the repository at this point in the history
…esolved-slow

Disable promise/no-multiple-resolved for speed
  • Loading branch information
chriszarate committed Oct 31, 2023
2 parents 329a5fe + 3d6aab9 commit 150c39b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
6 changes: 5 additions & 1 deletion configs/javascript.js
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,6 @@ module.exports = {
'promise/avoid-new': 'off',
'promise/catch-or-return': 'off',
'promise/no-callback-in-promise': 'warn',
'promise/no-multiple-resolved': 'error',
'promise/no-native': 'off',
'promise/no-nesting': 'warn',
'promise/no-new-statics': 'error',
Expand All @@ -244,6 +243,11 @@ module.exports = {
'promise/prefer-await-to-callbacks': 'off',
'promise/prefer-await-to-then': 'off',
'promise/valid-params': 'error',

// This rule has been disabled because it is extremely slow:
// https://github.com/Automattic/vip-cli/pull/1534
//
// 'promise/no-multiple-resolved': 'error',
},

settings: {
Expand Down
6 changes: 5 additions & 1 deletion configs/weak-javascript.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,16 @@ module.exports = {

radix: 'warn',

'promise/no-multiple-resolved': 'warn',
'promise/no-new-statics': 'warn',
'promise/no-return-in-finally': 'warn',
'promise/no-return-wrap': 'warn',
'promise/param-names': 'warn',
'promise/valid-params': 'warn',

// This rule has been disabled because it is extremely slow:
// https://github.com/Automattic/vip-cli/pull/1534
//
// 'promise/no-multiple-resolved': 'warn',
},
},
],
Expand Down

0 comments on commit 150c39b

Please sign in to comment.