Merge pull request #14 from Automattic/add/no-async-in-foreach

Add no-async-foreach rule
Automattic · Nov 21, 2018 · 837a9b1 · 837a9b1
2 parents 1018ca0 + 242e4ae
commit 837a9b1
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 27 deletions.
diff --git a/README.md b/README.md
@@ -16,7 +16,7 @@ To add `eslint-config-wpvip` to you project, first install it to `package.json`
 And install the required dependencies:
 
 ```
-npm i --save-dev babel-eslint@10 eslint@4 eslint-plugin-flowtype@3 eslint-plugin-import@2 eslint-plugin-jsx-a11y@6 eslint-plugin-react@7 eslint-plugin-wpcalypso@4 eslint-plugin-json@1
+npm i --save-dev babel-eslint@10 eslint@4 eslint-plugin-flowtype@3 eslint-plugin-import@2 eslint-plugin-jsx-a11y@6 eslint-plugin-react@7 eslint-plugin-wpcalypso@4 eslint-plugin-json@1 eslint-plugin-no-async-foreach
 ```
 
 Then in your `package.json`, add:

diff --git a/index.js b/index.js
@@ -19,6 +19,7 @@ module.exports = {
 		'wpcalypso',
 		'flowtype',
 		'json',
+		'no-async-foreach',
 	],
 	globals: {
 		describe: true,
@@ -64,6 +65,9 @@ module.exports = {
 		radix: [
 			'error',
 		],
+		'no-async-foreach/no-async-foreach': [
+			'error',
+		],
 	},
 	settings: {
 		react: {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -31,6 +31,7 @@
     "eslint-plugin-flowtype": "^3.0.0",
     "eslint-plugin-import": "^2.13.0",
     "eslint-plugin-jsx-a11y": "^6.1.1",
+    "eslint-plugin-no-async-foreach": "^0.1.1",
     "eslint-plugin-react": "^7.10.0",
     "eslint-plugin-wpcalypso": "^4.0.1",
     "eslint-plugin-json": "^1.2.1"
@@ -42,6 +43,7 @@
     "eslint-plugin-import": "2.14.0",
     "eslint-plugin-json": "1.2.1",
     "eslint-plugin-jsx-a11y": "6.1.2",
+    "eslint-plugin-no-async-foreach": "^0.1.1",
     "eslint-plugin-react": "7.11.1",
     "eslint-plugin-wpcalypso": "4.0.2"
   }