Add support for 'regexp' type and eql comparison of regular expressions. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchg
added a commit
that referenced
this pull request
Jun 4, 2013
Add support for 'regexp' type and eql comparison of regular expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for a
regexptype and equivalence comparisons of regular expressions usingeql. I'm working on a library that generates regular expressions and I'm using expect.js to do my testing, so having native support for regular expressions would be great. Let me know if you want anything changed in the implementation or if you think it does not belong in core.I've also updated the tests to account for the new functionality.