Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent time-based test failure #214

Open
coderkevin opened this issue Jul 11, 2019 · 0 comments
Open

Intermittent time-based test failure #214

coderkevin opened this issue Jul 11, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@coderkevin
Copy link
Contributor

I've noticed an intermittent time-based test failure, which probably indicates something is getting the "now" time by default assignment instead of being explicitly assigned in the tests. Something to look into:

Scheduler › getNextRequestDelay › returns the same number when a new request that is scheduled later is added

    expect(received).toBe(expected) // Object.is equality

    Expected: 119964
    Received: 119963

      261 | 			const delayAfter = scheduler.getNextRequestDelay( now );
      262 |
    > 263 | 			expect( delayAfter ).toBe( delayBefore );
          | 			                     ^
      264 | 		} );
      265 | 	} );
      266 |

      at Object.toBe (src/client/__tests__/scheduler.spec.js:263:25)

@coderkevin coderkevin added the bug Something isn't working label Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant