We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LocalCI server side always looks for a localci-new-strings.pot file (https://github.com/Automattic/gp-localci/blob/master/includes/ci-adapters/circle-ci-adapter.php#L87) -- even when it is empty. I personally think that's a good behavior as it gives us some assurance the client at least ran.
localci-new-strings.pot
Presuming we agree on that as desirable -- it means we need to always generate that file from the client even when we bail (https://github.com/Automattic/gp-localci-client/blob/master/generate-new-strings-pot.sh#L64). Otherwise we can cause false error responses at https://github.com/Automattic/gp-localci/blob/master/gp-localci.php#L65.
The text was updated successfully, but these errors were encountered:
Add move_pot_to_output function
1e689a8
This function should always get called before exit as the server checks for this file even when empty. Fixes #9.
No branches or pull requests
LocalCI server side always looks for a
localci-new-strings.pot
file (https://github.com/Automattic/gp-localci/blob/master/includes/ci-adapters/circle-ci-adapter.php#L87) -- even when it is empty. I personally think that's a good behavior as it gives us some assurance the client at least ran.Presuming we agree on that as desirable -- it means we need to always generate that file from the client even when we bail (https://github.com/Automattic/gp-localci-client/blob/master/generate-new-strings-pot.sh#L64). Otherwise we can cause false error responses at https://github.com/Automattic/gp-localci/blob/master/gp-localci.php#L65.
The text was updated successfully, but these errors were encountered: