Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always save out an empty .pot at minimum #9

Closed
mhsdef opened this issue May 10, 2017 · 0 comments
Closed

Always save out an empty .pot at minimum #9

mhsdef opened this issue May 10, 2017 · 0 comments

Comments

@mhsdef
Copy link
Contributor

mhsdef commented May 10, 2017

LocalCI server side always looks for a localci-new-strings.pot file (https://github.com/Automattic/gp-localci/blob/master/includes/ci-adapters/circle-ci-adapter.php#L87) -- even when it is empty. I personally think that's a good behavior as it gives us some assurance the client at least ran.

Presuming we agree on that as desirable -- it means we need to always generate that file from the client even when we bail (https://github.com/Automattic/gp-localci-client/blob/master/generate-new-strings-pot.sh#L64). Otherwise we can cause false error responses at https://github.com/Automattic/gp-localci/blob/master/gp-localci.php#L65.

mhsdef added a commit that referenced this issue May 12, 2017
This function should always get called before exit as the server checks for this file even when empty. Fixes #9.
@yoavf yoavf closed this as completed in #10 May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant