This repository has been archived by the owner on Feb 22, 2019. It is now read-only.
Allow adding translations to an existing jed object #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Adds new translations to the locale data, overwriting any existing translations with a matching key | ||
| **/ | ||
| I18N.prototype.addTranslations = function( localeData ) { | ||
| for ( var prop in localeData ) { |
There was a problem hiding this comment.
Can we use ES5 here? then we could do:
delete localeData[''];
Object.assign( this.state.jed.options.locale_data.messages, localeData );
There was a problem hiding this comment.
Or use lodash.merge and lodash.omit:
merge( this.state.jed.options.locale_data.messages, omit( localeData, '' ) )
akirk
force-pushed
the
add/addTranslations
branch
from
8f4b360
to
c7a1ec1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
addTranslations()which takes a translations object and adds it do the existing one. Fixes #8