Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub comments by ICFY currently have an issue with calculating totals for a particular "area". For example, for sections:
We see that the total is being calculated simply by adding up all the individual diffs for each group. This is incorrect, since groups can share chunks, and if a shared chunk changes size, it will be counted multiple times with this approach.
This PR instead takes shared chunks into account, by adding up all the chunks in use across an entire area for the "before" and "after" commits, and subtracting those sums instead (note: the values are slightly different because the above is from a PR and the below is from its merge):
This should reduce confusion, and more accurately convey the impact of a PR.