Bug fix: Identical !important rules are applied in the wrong order #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in the wrong order
|
@guille This is a pretty important issue to fix, what can I do to get this merged in? |
|
Is this repo still being maintained? |
|
+1 This bug got me in my current project. |
rauchg
added a commit
that referenced
this pull request
Oct 17, 2014
Bug fix: Identical !important rules are applied in the wrong order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very subtle bug caused by the fact that there's a shared specificity object for all !important rules, which messes up the compare function.
I included a unit test for the bug.