implement job.removeOnComplete, closes #383

Automattic · Aug 8, 2014 · b9b7e9d · b9b7e9d
1 parent 1fb1b98
commit b9b7e9d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/queue/job.js b/lib/queue/job.js
@@ -174,6 +174,7 @@ exports.get = function (id, fn) {
         job.updated_at = hash.updated_at;
         job.failed_at = hash.failed_at;
         job.duration = hash.duration;
+        job._removeOnComplete = hash._removeOnComplete;
         try {
             if (hash.data) job.data = JSON.parse(hash.data);
             if (hash.result) job.result = JSON.parse(hash.result);
@@ -389,6 +390,11 @@ Job.prototype.delay = function (ms) {
     return this;
 };
 
+Job.prototype.removeOnComplete = function (param) {
+    if (0 == arguments.length) return this._removeOnComplete;
+    this._removeOnComplete = param;
+    return this;
+};
 
 Job.prototype.backoff = function (param) {
     if (0 == arguments.length) return this._backoff;
@@ -681,6 +687,7 @@ Job.prototype.update = function (fn) {
 
     // delay
     if (this._delay) this.set('delay', this._delay);
+    if (this._removeOnComplete) this.set('removeOnComplete', this._removeOnComplete);
 
     if (this._backoff) {
         if (_.isPlainObject(this._backoff)) this.set('backoff', JSON.stringify(this._backoff) );

diff --git a/lib/queue/worker.js b/lib/queue/worker.js
@@ -171,6 +171,9 @@ Worker.prototype.process = function (job, fn) {
                     job.attempt( function(){
                         self.emit('job complete', job);
                         events.emit(job.id, 'complete', result);
+                        if( job.removeOnComplete() ) {
+                            job.remove();
+                        }
                     });
                 }.bind(this));
                 self.start(fn);