Tests for kue.js #778
Merged
Tests for kue.js #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like some of the bdd tests are failing, but not sure that's related to what I did here. All the failures are the same: |
|
Good stuff @tobalsgithub Can you check why tests are failing? |
|
See my comment right before yours. |
|
Actually, looks like |
|
Went ahead and updated the tests to fix the connection issues |
|
Strange! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates unit tests for the
kue.jsfile. We hope to create unit tests for the entire kue repo.Connects to #280
@behrad, we can either create individual PRs for each file, or keep adding to this PR as we get more tests written. Either way, I wanted to get this in front of you as quickly as possible so you had a chance to give feedback.