fix(setDefaultsOnInsert): set default if sibling of nested path is $set

Fix #11668
Automattic · Apr 27, 2022 · 25c7bce · 25c7bce
1 parent c3024b9
commit 25c7bce
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/lib/helpers/common.js b/lib/helpers/common.js
@@ -80,14 +80,6 @@ function modifiedPaths(update, path, result) {
 
     const _path = path + key;
     result[_path] = true;
-    if (_path.indexOf('.') !== -1) {
-      const sp = _path.split('.');
-      let cur = sp[0];
-      for (let i = 1; i < sp.length; ++i) {
-        result[cur] = true;
-        cur += '.' + sp[i];
-      }
-    }
     if (!Buffer.isBuffer(val) && isMongooseObject(val)) {
       val = val.toObject({ transform: false, virtuals: false });
     }

diff --git a/test/helpers/setDefaultsOnInsert.test.js b/test/helpers/setDefaultsOnInsert.test.js
@@ -72,4 +72,19 @@ describe('setDefaultsOnInsert', function() {
     assert.ok(!update.$setOnInsert['positions.$*']);
     assert.ok(update.$setOnInsert['positions'] instanceof Map);
   });
+
+  it('sets default if sibling of dotted path is $set (gh-11668)', async function() {
+    const schema = new Schema({
+      time: {
+        hit: { type: Number, default: 0 },
+        resolved: { type: Number, default: 42 }
+      }
+    });
+
+    const opts = { upsert: true };
+    let update = { $set: { 'time.hit': 100 } };
+    update = setDefaultsOnInsert({}, schema, update, opts);
+
+    assert.equal(update.$setOnInsert['time.resolved'], 42);
+  });
 });