chore: clean up a couple of lingering issues with #12680

Automattic · Apr 27, 2023 · 2e8cff3 · 2e8cff3
1 parent 7a3585e
commit 2e8cff3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/scripts/tsc-diagnostics-check.js b/scripts/tsc-diagnostics-check.js
@@ -3,7 +3,7 @@
 const fs = require('fs');
 
 const stdin = fs.readFileSync(0).toString('utf8');
-const maxInstantiations = isNaN(process.argv[2]) ? 110000 : parseInt(process.argv[2], 10);
+const maxInstantiations = isNaN(process.argv[2]) ? 120000 : parseInt(process.argv[2], 10);
 
 console.log(stdin);
 

diff --git a/test/types/document.test.ts b/test/types/document.test.ts
@@ -172,9 +172,7 @@ function gh11435() {
   const ItemSchema = new Schema<Item>({ name: String });
 
   ItemSchema.pre('validate', function preValidate() {
-    if (!(this instanceof Query)) {
-      expectType<Model<unknown>>(this.$model('Item1'));
-    }
+    expectType<Model<unknown>>(this.$model('Item1'));
   });
 }
 

diff --git a/types/middlewares.d.ts b/types/middlewares.d.ts
@@ -1,8 +1,8 @@
 declare module 'mongoose' {
 
-  type MongooseQueryAndDocumentMiddleware = 'updateOne' | 'deleteOne' | 'validate';
+  type MongooseQueryAndDocumentMiddleware = 'updateOne' | 'deleteOne';
 
-  type MongooseDistinctDocumentMiddleware = 'save' | 'init';
+  type MongooseDistinctDocumentMiddleware = 'save' | 'init' | 'validate';
   type MongooseDocumentMiddleware = MongooseDistinctDocumentMiddleware | MongooseQueryAndDocumentMiddleware;
 
   type MongooseDistinctQueryMiddleware = 'count' | 'estimatedDocumentCount' | 'countDocuments' | 'deleteMany' | 'distinct' | 'find' | 'findOne' | 'findOneAndDelete' | 'findOneAndRemove' | 'findOneAndReplace' | 'findOneAndUpdate' | 'replaceOne' | 'updateMany';