fixed; allow updating versionKey

closes #1265
Automattic · Feb 12, 2013 · 3af5152 · 3af5152
1 parent 556ab76
commit 3af5152
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/lib/model.js b/lib/model.js
@@ -1951,6 +1951,15 @@ Model._getSchema = function _getSchema (path) {
  */
 
 Model.compile = function compile (name, schema, collectionName, connection, base) {
+  var versioningEnabled = false !== schema.options.versionKey;
+
+  if (versioningEnabled && !schema.paths[schema.options.versionKey]) {
+    // add versioning to top level documents only
+    var o = {};
+    o[schema.options.versionKey] = Number;
+    schema.add(o);
+  }
+
   // generate new class
   function model (doc, fields, skipId) {
     if (!(this instanceof model))

diff --git a/lib/schema.js b/lib/schema.js
@@ -81,10 +81,7 @@ function Schema (obj, options) {
   if (autoid) {
     this.virtual('id').get(idGetter);
   }
-
-  // versioning not directly added to schema b/c we only want
-  // it in the top level document, not embedded ones.
-};
+}
 
 /*!
  * Returns this documents _id cast to a string.

diff --git a/test/versioning.test.js b/test/versioning.test.js
@@ -53,6 +53,12 @@ var BlogPost = new Schema({
 mongoose.model('Versioning', BlogPost);
 
 describe('versioning', function(){
+  it('is only added to parent schema (gh-1265)', function(done){
+    assert.ok(BlogPost.path('__v'));
+    assert.ok(!BlogPost.path('comments').__v);
+    assert.ok(!BlogPost.path('meta.nested').__v);
+    done();
+  })
 
   it('works', function (done) {
     var db = start()