Revert making map return vanilla JS Array

Automattic · Nov 19, 2019 · 4599877 · 4599877
1 parent ba38d1d
commit 4599877
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/lib/types/documentarray.js b/lib/types/documentarray.js
@@ -180,11 +180,6 @@ class CoreDocumentArray extends CoreMongooseArray {
     return arr;
   }
 
-  map() {
-    const arr = [].concat(Array.prototype.map.apply(this,arguments));
-    return arr;
-  }
-
   /**
    * Wraps [`Array#push`](https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Array/push) with proper change tracking.
    *

diff --git a/test/types.documentarray.test.js b/test/types.documentarray.test.js
@@ -576,15 +576,13 @@ describe('types.documentarray', function() {
       assert.equal(doc.docs.length, 2);
     });
 
-    it('map() works and does not return a mongoose array', function() {
+    it('map() works', function() {
       const personSchema = new Schema({ friends: [{ name: { type: String } }]});
       const Person = mongoose.model('gh8317-map', personSchema);
 
       const person = new Person({ friends: [{ name: 'Hafez' }] });
 
       const friendsNames = person.friends.map(friend => friend.name);
-      assert.deepEqual(friendsNames.constructor, Array);
-
       friendsNames.push('Sam');
 
       assert.equal(friendsNames.length, 2);