fix(schema): make ArraySubdocuments apply _id defaults on init

Fix #12264
Automattic · Aug 23, 2022 · 4a946ff · 4a946ff
1 parent 8c0800a
commit 4a946ff
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/schema/documentarray.js b/lib/schema/documentarray.js
@@ -392,7 +392,7 @@ DocumentArrayPath.prototype.getDefault = function(scope, init, options) {
 };
 
 const _toObjectOptions = Object.freeze({ transform: false, virtuals: false });
-const initDocumentOptions = Object.freeze({ skipId: true, willInit: true });
+const initDocumentOptions = Object.freeze({ skipId: false, willInit: true });
 
 /**
  * Casts contents

diff --git a/test/types.documentarray.test.js b/test/types.documentarray.test.js
@@ -748,4 +748,18 @@ describe('types.documentarray', function() {
     doc.arr.push(subdoc);
     await doc.validate();
   });
+
+  it('applies _id default (gh-12264)', function() {
+    mongoose.deleteModel(/Test/);
+    const nestedArraySchema = Schema({
+      subDocArray: [{ name: String }]
+    });
+
+    const Model = db.model('Test', nestedArraySchema);
+    const doc = new Model().init({
+      subDocArray: [{ name: 'foo' }]
+    });
+
+    assert.ok(doc.subDocArray[0]._id instanceof mongoose.Types.ObjectId);
+  });
 });