added; path to CastErrors

closes #1239
relates to #1232

lib/errors/cast.js

@@ -13,12 +13,13 @@ var MongooseError = require('../error');
  * @api private
  */
 
-function CastError (type, value) {
-  MongooseError.call(this, 'Cast to ' + type + ' failed for value "' + value + '"');
+function CastError (type, value, path) {
+  MongooseError.call(this, 'Cast to ' + type + ' failed for value "' + value + '" at path "' + path + '"');
   Error.captureStackTrace(this, arguments.callee);
   this.name = 'CastError';
   this.type = type;
   this.value = value;
+  this.path = path;
 };
 
 /*!

lib/schema/array.js

@@ -46,6 +46,7 @@ function SchemaArray (key, cast, options) {
     var caster = cast.name in Types ? Types[cast.name] : cast;
     this.casterConstructor = caster;
     this.caster = new caster(null, castOptions);
+    this.caster.path = key;
   }
 
   SchemaType.call(this, key, options);
@@ -121,7 +122,7 @@ SchemaArray.prototype.cast = function (value, doc, init) {
         }
       } catch (e) {
         // rethrow
-        throw new CastError(e.type, value);
+        throw new CastError(e.type, value, this.path);
       }
     }
 
@@ -151,15 +152,18 @@ SchemaArray.prototype.castForQuery = function ($conditional, value) {
     val = $conditional;
     var proto = this.casterConstructor.prototype;
     var method = proto.castForQuery || proto.cast;
+
+    var caster = this.caster;
     if (Array.isArray(val)) {
       val = val.map(function (v) {
-        if (method) v = method.call(proto, v);
+        if (method) v = method.call(caster, v);
+
         return isMongooseObject(v)
           ? v.toObject()
           : v;
       });
     } else if (method) {
-      val = method.call(proto, val);
+      val = method.call(caster, val);
     }
   }
   return val && isMongooseObject(val)

lib/schema/buffer.js

@@ -63,7 +63,7 @@ SchemaBuffer.prototype.cast = function (value, doc, init) {
     return new MongooseBuffer(value, [this.path, doc]);
   }
 
-  throw new CastError('buffer', value);
+  throw new CastError('buffer', value, this.path);
 };
 
 /*!

lib/schema/date.js

@@ -63,7 +63,7 @@ SchemaDate.prototype.cast = function (value) {
   if (date.toString() != 'Invalid Date')
     return date;
 
-  throw new CastError('date', value);
+  throw new CastError('date', value, this.path);
 };
 
 /*!

lib/schema/documentarray.js

@@ -7,7 +7,6 @@ var SchemaType = require('../schematype')
   , ArrayType = require('./array')
   , MongooseDocumentArray = require('../types/documentarray')
   , Subdocument = require('../types/embedded')
-  , CastError = SchemaType.CastError
   , Document = require('../document');
 
 /**

lib/schema/number.js

@@ -124,7 +124,7 @@ SchemaNumber.prototype.cast = function (value, doc, init) {
     }
   }
 
-  throw new CastError('number', value);
+  throw new CastError('number', value, this.path);
 };
 
 /*!

lib/schema/objectid.js

@@ -61,10 +61,15 @@ ObjectId.prototype.cast = function (value, scope, init) {
   if (value._id && value._id instanceof oid)
     return value._id;
 
-  if (value.toString)
-    return oid.fromString(value.toString());
+  if (value.toString) {
+    try {
+      return oid.fromString(value.toString());
+    } catch (err) {
+      throw new CastError('ObjectId', value, this.path);
+    }
+  }
 
-  throw new CastError('object id', value);
+  throw new CastError('ObjectId', value, this.path);
 };
 
 /*!

lib/schema/string.js

@@ -195,7 +195,7 @@ SchemaString.prototype.cast = function (value, scope, init) {
   if (SchemaType._isRef(this, value, init)) return value;
   if (value === null) return value;
   if ('undefined' !== typeof value && value.toString) return value.toString();
-  throw new CastError('string', value);
+  throw new CastError('string', value, this.path);
 };
 
 /*!

test/crash.test.js

@@ -25,9 +25,8 @@ describe('crash: (gh-407)', function(){
     }, function (err) {
       db.close();
 
-      // should is acting strange
       try {
-        assert.equal('Invalid ObjectId', err.message);
+        assert.equal('Cast to ObjectId failed for value "" at path "_id"', err.message);
       } catch (er) {
         console.error(err);
         throw er;

test/model.querying.test.js

@@ -877,10 +877,10 @@ describe('model: querying:', function(){
             assert.equal(1, nes1.length);
 
             NE.find({ b: { $ne: [1] }}, function (err, nes2) {
-              assert.equal("Invalid ObjectId", err.message);
+              assert.equal("Cast to ObjectId failed for value \"1\" at path \"b\"", err.message);
 
               NE.find({ b: { $ne: 4 }}, function (err, nes3) {
-                assert.equal("Invalid ObjectId", err.message);
+                assert.equal("Cast to ObjectId failed for value \"4\" at path \"b\"", err.message);
 
                 NE.find({ b: id3, ids: { $ne: id4 }}, function (err, nes4) {
                   db.close();
@@ -1689,7 +1689,7 @@ describe('buffers', function(){
           assert.equal(rb.block.toString('utf8'),'buffer shtuffs are neat');
 
           Test.findOne({ block: /buffer/i }, function (err, rb) {
-            assert.equal(err.message, 'Cast to buffer failed for value "/buffer/i"')
+            assert.equal(err.message, 'Cast to buffer failed for value "/buffer/i" at path "block"')
             Test.findOne({ block: [195, 188, 98, 101, 114] }, function (err, rb) {
               assert.ifError(err);
               assert.equal(rb.block.toString('utf8'),'über');

test/schema.test.js

@@ -587,7 +587,7 @@ describe('schema', function(){
         var M = db.model('castingStringArrayWithUndefined', schema);
         M.find({ arr: { $in: [undefined] }}, function (err) {
           db.close();
-          assert.equal(err && err.message, 'Cast to string failed for value "undefined"');
+          assert.equal(err && err.message, 'Cast to string failed for value "undefined" at path "arr"');
           done();
         });
       });

test/types.buffer.test.js

@@ -73,7 +73,7 @@ describe('types.buffer', function(){
           assert.equal(err.name, 'CastError');
           assert.equal(err.type, 'buffer');
           assert.equal(err.value, 20);
-          assert.equal(err.message, 'Cast to buffer failed for value "20"');
+          assert.equal(err.message, 'Cast to buffer failed for value "20" at path "required"');
           t.required = new Buffer("hello");
 
           t.sub.push({ name: 'Friday Friday' });