fixed; compat with non-schema path props using positional notation

fixes #1048
Automattic · Aug 16, 2012 · 6dd0503 · 6dd0503
1 parent 33d6dc9
commit 6dd0503
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 5 deletions.
diff --git a/lib/schema.js b/lib/schema.js
@@ -358,12 +358,15 @@ function getPositionalPath (self, path) {
     return self.paths[subpaths[0]];
   }
 
-  var val = self.path(subpaths[0])
-    , last = subpaths.length - 1
-    , subpath;
+  var val = self.path(subpaths[0]);
+  if (!val) return val;
 
-  for (var i = 1; i < subpaths.length; ++i) {
-    var subpath = subpaths[i];
+  var last = subpaths.length - 1
+    , subpath
+    , i = 1;
+
+  for (; i < subpaths.length; ++i) {
+    subpath = subpaths[i];
 
     if (i === last &&
         val &&

diff --git a/test/model.test.js b/test/model.test.js
@@ -3955,6 +3955,36 @@ describe('model', function(){
         done();
       });
     });
+
+    it('with positional notation on path not existing in schema (gh-1048)', function(done){
+      var db = start();
+
+      var M = db.model('backwardCompat-gh-1048', Schema({ name: 'string' }));
+      db.on('open', function () {
+        var o = {
+            name: 'gh-1048'
+          , _id: new mongoose.Types.ObjectId
+          , databases: {
+                0: { keys: 100, expires: 0}
+              , 15: {keys:1,expires:0}
+            }
+        };
+
+        M.collection.insert(o, { safe: true }, function (err) {
+          assert.ifError(err);
+          M.findById(o._id, function (err, doc) {
+            db.close();
+            assert.ifError(err);
+            assert.ok(doc);
+            assert.ok(doc._doc.databases);
+            assert.ok(doc._doc.databases['0']);
+            assert.ok(doc._doc.databases['15']);
+            assert.equal(undefined, doc.databases);
+            done();
+          })
+        })
+      });
+    })
   });
 
   describe('create()', function(){