Merge pull request #11186 from Automattic/gh-11071

Gh 11071

lib/document.js

@@ -2239,7 +2239,9 @@ Document.prototype.isSelected = function isSelected(path) {
   if (this.$__.selected == null) {
     return true;
   }
-
+  if (!path) {
+    return false;
+  }
   if (path === '_id') {
     return this.$__.selected._id !== 0;
   }

lib/model.js

@@ -825,7 +825,6 @@ function checkDivergentArray(doc, path, array) {
 
 Model.prototype.$__version = function(where, delta) {
   const key = this.$__schema.options.versionKey;
-
   if (where === true) {
     // this is an insert
     if (key) {
@@ -834,12 +833,17 @@ Model.prototype.$__version = function(where, delta) {
     return;
   }
 
+  if (key === false) {
+    return;
+  }
+
   // updates
 
   // only apply versioning if our versionKey was selected. else
   // there is no way to select the correct version. we could fail
   // fast here and force them to include the versionKey but
   // thats a bit intrusive. can we do this automatically?
+
   if (!this.$__isSelected(key)) {
     return;
   }

test/model.test.js

@@ -7562,6 +7562,33 @@ describe('Model', function() {
       assert.ok(err == null);
 
     });
+    it('Using bulkSave should not trigger an error (gh-11071)', async function() {
+
+      const pairSchema = mongoose.Schema({
+        name: String,
+        timestamp: String
+      }, { versionKey: false });
+
+      const model = db.model('test', pairSchema);
+      const tests = [
+        { name: 't1', timestamp: Date.now() },
+        { name: 't2', timestamp: Date.now() },
+        { name: 't3', timestamp: Date.now() },
+        { name: 't4', timestamp: Date.now() }
+      ];
+
+      model.insertMany(tests, {
+        ordered: false
+      });
+      const entries = await model.find({});
+      for (const p of entries) {
+        p.timestamp = Date.now();
+      }
+
+      // !!! "TypeError: path.indexOf is not a function" occurs here
+      const res = await model.bulkSave(entries);
+      assert.ok(res);
+    });
   });
 
   describe('Setting the explain flag', function() {