Merge pull request #12569 from Automattic/vkarpov15/gh-12480

fix(document): allow creating document with document array and top-level key named `schema`
Automattic · Oct 20, 2022 · 9133393 · 9133393
2 parents 03f19f5 + 3141cb6
commit 9133393
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/types/DocumentArray/index.js b/lib/types/DocumentArray/index.js
@@ -57,7 +57,7 @@ function MongooseDocumentArray(values, path, doc) {
   // to make more proof against unusual node environments
   if (doc && doc instanceof Document) {
     internals[arrayParentSymbol] = doc;
-    internals[arraySchemaSymbol] = doc.schema.path(path);
+    internals[arraySchemaSymbol] = doc.$__schema.path(path);
 
     // `schema.path()` doesn't drill into nested arrays properly yet, see
     // gh-6398, gh-6602. This is a workaround because nested arrays are

diff --git a/test/document.test.js b/test/document.test.js
@@ -11928,6 +11928,26 @@ describe('document', function() {
     assert.ok(rawDoc);
     assert.deepStrictEqual(rawDoc.tags, ['mongodb']);
   });
+
+  it('can create document with document array and top-level key named `schema` (gh-12480)', async function() {
+    const AuthorSchema = new Schema({
+      fullName: { type: 'String', required: true }
+    });
+
+    const BookSchema = new Schema({
+      schema: { type: 'String', required: true },
+      title: { type: 'String', required: true },
+      authors: [AuthorSchema]
+    }, { supressReservedKeysWarning: true });
+
+    const Book = db.model('Book', BookSchema);
+
+    await Book.create({
+      schema: 'design',
+      authors: [{ fullName: 'Sourabh Bagrecha' }],
+      title: 'The power of JavaScript'
+    });
+  });
 });
 
 describe('Check if instance function that is supplied in schema option is availabe', function() {