fix(schema): also propagate typePojoToMixed option to schemas impli…

…citly created because of `typePojoToMixed` Fix #8627
Automattic · Mar 7, 2020 · b4b61d3 · b4b61d3
1 parent 1cd05dd
commit b4b61d3
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/schema.js b/lib/schema.js
@@ -507,7 +507,10 @@ Schema.prototype.add = function add(obj, prefix) {
         if (prefix) {
           this.nested[prefix.substr(0, prefix.length - 1)] = true;
         }
-        const schemaWrappedPath = Object.assign({}, obj[key], { type: new Schema(obj[key][this.options.typeKey]) });
+        // Propage `typePojoToMixed` to implicitly created schemas
+        const opts = { typePojoToMixed: false };
+        const _schema = new Schema(obj[key][this.options.typeKey], opts);
+        const schemaWrappedPath = Object.assign({}, obj[key], { type: _schema });
         this.path(prefix + key, schemaWrappedPath);
       } else {
         // Either the type is non-POJO or we interpret it as Mixed anyway

diff --git a/test/types.embeddeddocumentdeclarative.test.js b/test/types.embeddeddocumentdeclarative.test.js
@@ -82,6 +82,23 @@ describe('types.embeddeddocumentdeclarative', function() {
         assert.ok(schema.path('arr').schema.path('nested').instance !== 'Mixed');
         assert.ok(schema.path('arr').schema.path('nested.test') instanceof mongoose.Schema.Types.String);
       });
+
+      it('nested array (gh-8627)', function() {
+        const schema = new Schema({
+          l1: {
+            type: {
+              l2: {
+                type: {
+                  test: String
+                }
+              }
+            }
+          }
+        }, { typePojoToMixed: false });
+
+        assert.ok(schema.path('l1').instance !== 'Mixed');
+        assert.ok(schema.path('l1.l2').instance !== 'Mixed');
+      });
     });
   });
   describe('with a parent with a POJO field with a field "type" with a type set to "String"', function() {