Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] support named parameters #10367

Open
AbdelrahmanHafez opened this issue Jun 17, 2021 · 0 comments
Open

[Feature] support named parameters #10367

AbdelrahmanHafez opened this issue Jun 17, 2021 · 0 comments
Assignees
@AbdelrahmanHafez
Labels
enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature
Milestone
7.x Unprioritized

Comments

@AbdelrahmanHafez
Copy link
Collaborator

re #10360 (comment)
It would be nice if we support named parameters for mongoose methods.
It should be straightforward to implement, I'll start with the following:

  • Model.find
  • Model.findOne
  • Model.updateOne
  • Model.updateMany
  • Model.countDocuments
  • Model.validate
  • Model.aggregate
  • Model.exists

Then we can decide what other functions we can apply the pattern to.
@AbdelrahmanHafez AbdelrahmanHafez self-assigned this Jun 17, 2021
@AbdelrahmanHafez AbdelrahmanHafez added new feature This change adds new functionality, like a new method or class enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature and removed new feature This change adds new functionality, like a new method or class labels Jun 17, 2021
@AbdelrahmanHafez AbdelrahmanHafez mentioned this issue Jun 19, 2021
Merged
AbdelrahmanHafez added a commit to AbdelrahmanHafez/mongoose that referenced this issue Jun 19, 2021
@AbdelrahmanHafez
test(model): add test for named parameters re Automattic#10367
5a62c37
@vkarpov15 vkarpov15 added this to the 5.x Unprioritized milestone Jun 23, 2021
@AbdelrahmanHafez AbdelrahmanHafez mentioned this issue Jun 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbdelrahmanHafez AbdelrahmanHafez

Labels
enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature
Projects
None yet
Milestone
7.x Unprioritized
Development

No branches or pull requests
2 participants
@vkarpov15 @AbdelrahmanHafez