Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(document): add support for pathsToSkip in validate and validateSync #10375

Merged
merged 12 commits into from
Jun 23, 2021

Conversation

AbdelrahmanHafez
Copy link
Collaborator

fixes #10353

This still doesn't add support for pathsToSkip for Model.validate(...)` because the current parameters are:

Model.validate = function validate(obj, pathsToValidate, context, callback) { ... }

We can not add it as a property to any of those parameters, so I'll defer implementing it until #10367 is implemented, then it'll make our lives much easier to extend our API.

lib/document.js Outdated Show resolved Hide resolved
lib/document.js Show resolved Hide resolved
lib/document.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@IslandRhythms IslandRhythms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto everything Val said

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 5.13 milestone Jun 23, 2021
@vkarpov15 vkarpov15 merged commit 37fe808 into Automattic:5.13 Jun 23, 2021
@AbdelrahmanHafez AbdelrahmanHafez deleted the feat/pathsToSkip branch June 24, 2021 01:46
@AbdelrahmanHafez
Copy link
Collaborator Author

Happy to help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants