Timestamps are not being created #10447

lbertoncello · 2021-07-12T14:19:42Z

I'm trying to add timestamps to my nested objects, but it's not working. Timestamps are being set only on the root documents (Church). Am I doing something wrong?

Here's my schemas:

const churchSchema = new Schema({
	churchId: {
		type: Number,
		required: true,
	},
	integration: {
		type: Integration,
		required: true,
	},
	service: {
		type: Service,
		required: true,
	},
	events: {
		type: [ Event ],
		required: false,
	},
}, {
	timestamps: true,
});

const eventSchema = new Schema({
	churchId: {
		type: Number,
		required: true,
	},
	code: {
		type: String,
		required: true,
	},
	template: {
		type: Template,
		required: true,
	},
	users: {
		type: [ User ],
		required: false,
	},
	message: {
		type: Message,
		required: true,
	},
}, {
	timestamps: true,
}

const userSchema = new Schema({
	churchId: {
		type: Number,
		required: true,
	},
	email: {
		type: String,
		required: true,
	},
	fullname: {
		type: String,
		required: true,
	},
	dateOfBirth: {
		type: Date,
		required: true,
	},
	contacted: {
		type: Boolean,
		required: true,
		default: false,
	},
}, {
	timestamps: true,
});

Here's the function I'm using to insert nested documents:

churchSchema.methods.addUserToEvent = async function (user, eventCode) {
	return await mongoose.model('Church').findOneAndUpdate({
		_id: this._id,
		events: {
			$elemMatch: {
				code: eventCode,
				users: {
					$not: {
						$elemMatch: {
							email: user.email,
						},
					},
				},
			},
		},
	}, {
		$addToSet: {
			'events.$.users': user,
		},
	}, {
		upsert: true,
		new: true,
		timestamps: true,
	});
};

MongoDB: 4.4.6
Mongoose: 5.13.2
Node.js: v14.17.0

The text was updated successfully, but these errors were encountered:

IslandRhythms · 2021-07-12T14:35:08Z

Please include model creation. Also, are those mixed Schemas you are using?

lbertoncello · 2021-07-12T14:42:03Z

const mongoose = require('mongoose');
const Schema = mongoose.Schema;
const mongoosePaginate = require('mongoose-paginate-v2');

const Event = require('../Event');
const Service = require('../Service');
const Integration = require('../Integration');

const eventCodes = {
	aniversary: 'USUARIO_ANIVERSARIANTE',
	welcome: 'USUARIO_NOVO_CADASTRO',
};

const churchSchema = new Schema({
	churchId: {
		type: Number,
		required: true,
	},
	integration: {
		type: Integration,
		required: true,
	},
	service: {
		type: Service,
		required: true,
	},
	events: {
		type: [ Event ],
		required: false,
	},
}, {
	timestamps: true,
});


/*
 * Plugins
 */
churchSchema.plugin(mongoosePaginate);

/*
 * Indexes
 */
churchSchema.index({ churchId: 1 }, { unique: true });

/*
 * Query helpers
 */
churchSchema.query.byChurchId = async function (churchId) {
	return await this.where({ churchId: churchId });
};

churchSchema.query.byEventCode = async function (code) {
	return await this.where({ 'events.code': code });
};

churchSchema.query.byEventchurchId = async function (churchId) {
	return await this.where({ 'events.churchId': churchId });
};

churchSchema.query.byTemplatechurchId = async function (churchId) {
	return await this.where({ 'events.template.churchId': churchId });
};

churchSchema.query.hasEvent = async function (eventCode) {
	return await this.where({ 'events.code': eventCode });
};


/*
 * Instance methods
 */
churchSchema.methods.getEvent = async function (eventCode) {
	return (await mongoose.model('Church').find({
		_id: this._id,
	}).
		select({
			events: {
				$elemMatch: {
					code: eventCode,
				},
			},
			churchId: true,
		}))[0].events[0];
};

churchSchema.methods.getAniversaryEvent = async function () {
	return await this.getEvent(eventCodes.aniversary);
};

churchSchema.methods.getWelcomeEvent = async function () {
	return await this.getEvent(eventCodes.welcome);
};

churchSchema.methods.addUserToEvent = async function (user, eventCode) {
	return await mongoose.model('Church').findOneAndUpdate({
		_id: this._id,
		events: {
			$elemMatch: {
				code: eventCode,
				users: {
					$not: {
						$elemMatch: {
							email: user.email,
						},
					},
				},
			},
		},
	}, {
		$push: {
			'events.$.users': user,
		},
	}, {
		upsert: false,
		new: true,
	});
};

churchSchema.methods.addUsersToAniversaryEvent = async function (users) {
	return await this.addUsersToEvent(eventCodes.aniversary, users);
};

churchSchema.methods.addUsersToWelcomeEvent = async function (users) {
	return await this.addUsersToEvent(eventCodes.welcome, users);
};

/*
 * Static methods
 */
churchSchema.statics.insertIfNotExists = async function (doc) {
	const query = { churchId: doc.churchId };
	const update = {
		$setOnInsert: {
			id: doc.churchId,
			integration: doc.integration,
			service: doc.service,
			events: doc.events,
		},
	};
	const options = { upsert: true };

	return await mongoose.model('Church').
		findOneAndUpdate(query, update, options);
};

churchSchema.statics.getEventCodes = function () {
	return eventCodes;
};


churchSchema.statics.getUsersNotContacted = async function (
	churchId,
	eventCode,
) {
	return await mongoose.model('Church').aggregate([
		{
			$match: {
				churchId: churchId,
			},
		},
		{
			$project: {
				churchId: 1,
				events: 1,
			},
		},
		{
			$unwind: {
				path: '$events',
				preserveNullAndEmptyArrays: false,
			},
		},
		{
			$match: {
				'events.code': eventCode,
			},
		},
		{
			$unwind: {
				path: '$events.users',
				preserveNullAndEmptyArrays: false,
			},
		},
		{
			$match: {
				'events.users.contacted': false,
			},
		},
		{
			$group: {
				_id: '$_id',
				churchId: {
					$first: '$churchId',
				},
				users: {
					$push: '$events.users',
				},
			},
		},
	]);
};

mongoose.model('Church', churchSchema);

lbertoncello · 2021-07-12T14:42:24Z

const mongoose = require('mongoose');
const Schema = mongoose.Schema;

const Template = require('../Template');
const User = require('../User');
const Message = require('../Message');

const eventSchema = new Schema({
	churchId: {
		type: Number,
		required: true,
	},
	code: {
		type: String,
		required: true,
	},
	template: {
		type: Template,
		required: true,
	},
	users: {
		type: [ User ],
		required: false,
	},
	message: {
		type: Message,
		required: true,
	},
}, {
	timestamps: true,
});

/*
 * Indexes
 */
eventSchema.index({ churchId: 1 }, { unique: true });


/*
 * Query helpers
 */
eventSchema.query.byCode = function (code) {
	return this.where({ code: code });
};

eventSchema.query.onlyAniversary = function () {
	const code = 'USUARIO_ANIVERSARIANTE';

	return this.where({ code: code });
};

eventSchema.query.onlyWelcome = function () {
	const code = 'USUARIO_NOVO_CADASTRO';

	return this.where({ code: code });
};

/*
 * Static methods
 */


mongoose.model('Event', eventSchema);

lbertoncello · 2021-07-12T14:42:34Z

const mongoose = require('mongoose');
const Schema = mongoose.Schema;

const userSchema = new Schema({
	email: {
		type: String,
		required: true,
	},
	churchId: {
		type: Number,
		required: true,
	},
	fullname: {
		type: String,
		required: true,
	},
	dateOfBirth: {
		type: Date,
		required: true,
	},
	contacted: {
		type: Boolean,
		required: true,
		default: false,
	},
}, {
	timestamps: true,
});

/*
 * Indexes
 */
userSchema.index({
	email: 1,
	churchId: 1,
}, { unique: true });

/*
 * Query helpers
 */
userSchema.query.byEmail = function (email) {
	return this.where({ email: email });
};


userSchema.query.byDateOfBirth = function (dateOfBirth) {
	return this.where({ dateOfBirth: dateOfBirth });
};

userSchema.query.byDateOfBirthGteThan = function (dateOfBirth) {
	return this.where({
		dateOfBirth: {
			$gte: dateOfBirth,
		},
	});
};

userSchema.query.byDateOfBirthLteThan = function (dateOfBirth) {
	return this.where({
		dateOfBirth: {
			$lte: dateOfBirth,
		},
	});
};

userSchema.query.byDateOfBirthBetween = function (startDate, endDate) {
	return this.where({
		dateOfBirth: {
			$gte: startDate,
			$lte: endDate,
		},
	});
};

mongoose.model('User', userSchema);

lbertoncello · 2021-07-12T14:44:26Z

Also, are those mixed Schemas you are using?

Do you need something else?

IslandRhythms · 2021-07-12T14:46:20Z

Integration and Service

lbertoncello · 2021-07-12T14:54:39Z

const mongoose = require('mongoose');
const Schema = mongoose.Schema;

const integrationSchema = new Schema({
	churchId: {
		type: Number,
		required: true,
	},
}, {
	_id: false,
});

/*
 * Indexes
 */


/*
 * Query helpers
 */


/*
 * Instance methods
 */

mongoose.model('Integration', integrationSchema);

lbertoncello · 2021-07-12T14:54:48Z

const mongoose = require('mongoose');
const Schema = mongoose.Schema;

const serviceSchema = new Schema({
	churchId: {
		type: Number,
		required: true,
	},
	code: {
		type: String,
		required: true,
	},
}, {
	_id: false,
});

/*
 * Indexes
 */


/*
 * Query helpers
 */


/*
 * Instance methods
 */

mongoose.model('Service', serviceSchema);

lbertoncello · 2021-07-12T14:55:35Z

const mongoose = require('mongoose');
const Schema = mongoose.Schema;

const messageSchema = new Schema({
	numberOfMessages: {
		type: Number,
		required: true,
		default: '0',
	},
}, {
	timestamps: true,
});

mongoose.model('Message', messageSchema);

lbertoncello · 2021-07-12T14:56:23Z

Integration and Service

Let me know if you need anything else

IslandRhythms · 2021-07-12T15:07:38Z

And you're not getting an error message at all?

lbertoncello · 2021-07-12T15:14:34Z

And you're not getting an error message at all?

No, I'm not receiving any error messages. Everything runs fine, but when I check my database, there is no "createdAt" or "updatedAt" in users or events, only in churches.

lbertoncello · 2021-07-12T15:17:15Z

Here is an example

/** 
* Paste one or more documents here
*/
/** 
* Paste one or more documents here
*/
{
    "churchId": 5,
    "__v": 0,
    "createdAt": {
        "$date": "2021-07-12T13:55:08.663Z"
    },
    "events": [{
        "users": [{
            "contacted": false,
            "_id": {
                "$oid": "60ec49c1d5a6a8457c6c8ba7"
            },
            "email": "lucast09@gmail.com",
            "churchId": 5,
            "fullname": "Lucas Teste 09",
            "dateOfBirth": {
                "$date": "2020-07-12T00:00:00.000Z"
            }
        }, {
            "contacted": false,
            "_id": {
                "$oid": "60ec49c1d5a6a8457c6c8ba8"
            },
            "email": "lucast10@gmail.com",
            "churchId": 5,
            "fullname": "Lucas Teste 10",
            "dateOfBirth": {
                "$date": "2020-07-12T00:00:00.000Z"
            }
        }],
        "_id": {
            "$oid": "60ec49bcd5a6a8457c6c8b9a"
        },
        "template": {
            "churchId": 1,
            "template": "Feliz aniversário {{usuario.nome}}!"
        },
        "churchId": 1,
        "code": "USUARIO_ANIVERSARIANTE"
    }, {
        "users": [{
            "contacted": false,
            "_id": {
                "$oid": "60ec49bed5a6a8457c6c8b9e"
            },
            "email": "lucast10@gmail.com",
            "churchId": 5,
            "fullname": "Lucas Teste 10"
        }, {
            "contacted": false,
            "_id": {
                "$oid": "60ec49bed5a6a8457c6c8b9f"
            },
            "email": "lucast09@gmail.com",
            "churchId": 5,
            "fullname": "Lucas Teste 09"
        }, {
            "contacted": false,
            "_id": {
                "$oid": "60ec49bed5a6a8457c6c8ba0"
            },
            "email": "lucast08@gmail.com",
            "churchId": 5,
            "fullname": "Lucas Teste 08"
        }, {
            "contacted": false,
            "_id": {
                "$oid": "60ec49bed5a6a8457c6c8ba1"
            },
            "email": "lucast07@gmail.com",
            "churchId": 5,
            "fullname": "Lucas Teste 07"
        }],
        "_id": {
            "$oid": "60ec49bcd5a6a8457c6c8b9b"
        },
        "template": {
            "churchId": 2,
            "template": "Seja bem-vindo {{usuario.nome}}!"
        },
        "churchId": 2,
        "code": "USUARIO_NOVO_CADASTRO"
    }],
    "integration": {
        "churchId": 1
    },
    "service": {
        "churchId": 1,
        "code": "WHATS_APP"
    },
    "updatedAt": {
        "$date": "2021-07-12T13:55:13.176Z"
    }
}

IslandRhythms · 2021-07-12T17:53:54Z

const mongoose = require('mongoose');
const {Schema} = mongoose;

const userSchema = new Schema({
	email: {
		type: String,
		required: true,
	},
	fullname: {
		type: String,
		required: true,
	},
	dateOfBirth: {
		type: Date,
		required: true,
	},
	contacted: {
		type: Boolean,
		required: true,
		default: false,
	},
}, {
	timestamps: true,
});

const eventSchema = new Schema({
	code: {
		type: String,
		required: true,
	},
	template: String,
	users: {
		type: [ userSchema ],
		required: false,
	},
	message: String,
}, {
	timestamps: true,
});


const churchSchema = new Schema({
	integration: String,
	service: String,
	events: {
		type: [ eventSchema ],
		required: false,
	},
}, {
	timestamps: true,
});

const Test = mongoose.model('Church', churchSchema);
async function run() {
    await mongoose.connect('mongodb://localhost:27017/test', {
        useNewUrlParser: true,
        useUnifiedTopology: true,
      });
      await mongoose.connection.dropDatabase();
    
     const entry = await Test.create({integration: 'Hello', service: 'world', events: [{code: 'A', template: 'B', users:[{email:'Test@testerson.com', fullname: 'Fullname', dateOfBirth: new Date(), contacted: true}],message:'message'}]})
     const result = await Test.findOneAndUpdate({_id: entry._id, events: {$elemMatch: {code: 'A'}}}, {$addToSet: {'events.$.users':{email: 'randal@test.com', fullName: 'fred', dateOfBirth: new Date(), contacted: true}}},{upsert: true, new: true, timestamps: true});
      console.log(result);
      console.log(result.events[0].users)
}

run();

lbertoncello · 2021-07-12T18:07:58Z

const mongoose = require('mongoose');
const {Schema} = mongoose;

const userSchema = new Schema({
	email: {
		type: String,
		required: true,
	},
	fullname: {
		type: String,
		required: true,
	},
	dateOfBirth: {
		type: Date,
		required: true,
	},
	contacted: {
		type: Boolean,
		required: true,
		default: false,
	},
}, {
	timestamps: true,
});

const eventSchema = new Schema({
	code: {
		type: String,
		required: true,
	},
	template: String,
	users: {
		type: [ userSchema ],
		required: false,
	},
	message: String,
}, {
	timestamps: true,
});


const churchSchema = new Schema({
	integration: String,
	service: String,
	events: {
		type: [ eventSchema ],
		required: false,
	},
}, {
	timestamps: true,
});

const Test = mongoose.model('Church', churchSchema);
async function run() {
    await mongoose.connect('mongodb://localhost:27017/test', {
        useNewUrlParser: true,
        useUnifiedTopology: true,
      });
      await mongoose.connection.dropDatabase();
    
     const entry = await Test.create({integration: 'Hello', service: 'world', events: [{code: 'A', template: 'B', users:[{email:'Test@testerson.com', fullname: 'Fullname', dateOfBirth: new Date(), contacted: true}],message:'message'}]})
     const result = await Test.findOneAndUpdate({_id: entry._id, events: {$elemMatch: {code: 'A'}}}, {$addToSet: {'events.$.users':{email: 'randal@test.com', fullName: 'fred', dateOfBirth: new Date(), contacted: true}}},{upsert: true, new: true, timestamps: true});
      console.log(result);
      console.log(result.events[0].users)
}

run();

I've tried to run and it worked but I didn't understand, is it a bug or a mistake of mine?

IslandRhythms · 2021-07-12T19:20:01Z

when you ran it you saw timestamps where they should be?

lbertoncello · 2021-07-12T19:26:15Z

when you ran it you saw timestamps where they should be?

Yes.

IslandRhythms · 2021-07-12T19:27:30Z

paste your output please.

lbertoncello · 2021-07-12T19:42:00Z

paste your output please.

node .\test.js
(node:25180) DeprecationWarning: Mongoose: `findOneAndUpdate()` and `findOneAndDelete()` without the `useFindAndModify` option set to false are deprecated. See: https://mongoosejs.com/docs/deprecations.html#findandmodify
(Use `node --trace-deprecation ...` to show where the warning was created)
{
  _id: 60ec836110e61f625c7750ff,
  integration: 'Hello',
  service: 'world',
  events: [
    {
      _id: 60ec836110e61f625c775100,
      code: 'A',
      template: 'B',
      users: [Array],
      message: 'message',
      createdAt: 2021-07-12T18:01:05.897Z,
      updatedAt: 2021-07-12T18:01:05.897Z
    }
  ],
  createdAt: 2021-07-12T18:01:05.897Z,
  updatedAt: 2021-07-12T18:01:05.917Z,
  __v: 0
}
[
  {
    contacted: true,
    _id: 60ec836110e61f625c775101,
    email: 'Test@testerson.com',
    fullname: 'Fullname',
    dateOfBirth: 2021-07-12T18:01:05.887Z,
    createdAt: 2021-07-12T18:01:05.897Z,
    updatedAt: 2021-07-12T18:01:05.897Z
  },
  {
    contacted: true,
    _id: 60ec836110e61f625c775103,
    email: 'randal@test.com',
    dateOfBirth: 2021-07-12T18:01:05.915Z
  }
]

IslandRhythms · 2021-07-12T19:43:06Z

{
contacted: true,
_id: 60ec836110e61f625c775103,
email: 'randal@test.com',
dateOfBirth: 2021-07-12T18:01:05.915Z
}

this should have timestamps correct?

lbertoncello · 2021-07-12T19:45:57Z

{
contacted: true,
_id: 60ec836110e61f625c775103,
email: 'randal@test.com',
dateOfBirth: 2021-07-12T18:01:05.915Z
}

this should have timestamps correct?

Yes, you're right! Sorry, I didn't notice the only the first user has a timestamp.

lbertoncello · 2021-07-12T19:47:23Z

@IslandRhythms So the problem is in findOneAndUpdate?

IslandRhythms · 2021-07-12T19:48:33Z

We'll have to investigate so can't really say right now. This is a bug

lbertoncello · 2021-07-12T19:53:34Z

We'll have to investigate so can't really say right now. This is a bug

Okay, let me know if I can do anything to help.

sanket-hv · 2023-09-01T11:09:34Z

I did this await Wallpaper.create(data, {session}) instead of
let wallpaper = new Wallpaper(data, { session })
wallpaper = await wallpaper.save()
and it works for me.

adityamms · 2023-09-06T02:56:04Z

I did this await Wallpaper.create(data, {session}) instead of let wallpaper = new Wallpaper(data, { session }) wallpaper = await wallpaper.save() and it works for me.

this is work well for me ,thanks brother

sanket-hv · 2023-09-06T03:15:08Z

It's my pleasure to contribute towards the community.

…

On Wed, 6 Sep 2023 at 8:26 AM, Aditya Marzuk ***@***.***> wrote: I did this *await Wallpaper.create(data, {session})* instead of *let wallpaper = new Wallpaper(data, { session }) wallpaper = await wallpaper.save()* and it works for me. this is work well for me ,thanks brother — Reply to this email directly, view it on GitHub <#10447 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANMEKBDOJLETS2POJO5MJMTXY7Q47ANCNFSM5AG6MI3Q> . You are receiving this because you commented.Message ID: ***@***.***>

rajathongal · 2023-09-10T08:23:44Z

We'll have to investigate so can't really say right now. This is a bug

This issue with timestamps is still there and also strict is not working @IslandRhythms

vkarpov15 · 2023-09-18T15:31:44Z

@rajathongal please open a new issue and follow the issue template

IslandRhythms added the confirmed-bug We've confirmed this is a bug in Mongoose and will fix it. label Jul 12, 2021

vkarpov15 added this to the 5.13.3 milestone Jul 13, 2021

vkarpov15 added a commit that referenced this issue Jul 16, 2021

test(timestamps): repro #10447

c6a646c

vkarpov15 closed this as completed in 66fd25f Jul 16, 2021

lbertoncello mentioned this issue Jul 16, 2021

Timestamps are not being created when using $setOnInsert #10460

Closed

Automattic locked as resolved and limited conversation to collaborators Sep 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Timestamps are not being created #10447

Timestamps are not being created #10447

lbertoncello commented Jul 12, 2021 •

edited

IslandRhythms commented Jul 12, 2021 •

edited

lbertoncello commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

lbertoncello commented Jul 12, 2021 •

edited

lbertoncello commented Jul 12, 2021

IslandRhythms commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

IslandRhythms commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

IslandRhythms commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

IslandRhythms commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

IslandRhythms commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

IslandRhythms commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

IslandRhythms commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

sanket-hv commented Sep 1, 2023

adityamms commented Sep 6, 2023

sanket-hv commented Sep 6, 2023 via email

rajathongal commented Sep 10, 2023 •

edited

vkarpov15 commented Sep 18, 2023

Timestamps are not being created #10447

Timestamps are not being created #10447

Comments

lbertoncello commented Jul 12, 2021 • edited

IslandRhythms commented Jul 12, 2021 • edited

lbertoncello commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

lbertoncello commented Jul 12, 2021 • edited

lbertoncello commented Jul 12, 2021

IslandRhythms commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

IslandRhythms commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

IslandRhythms commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

IslandRhythms commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

IslandRhythms commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

IslandRhythms commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

IslandRhythms commented Jul 12, 2021

lbertoncello commented Jul 12, 2021

sanket-hv commented Sep 1, 2023

adityamms commented Sep 6, 2023

sanket-hv commented Sep 6, 2023 via email

rajathongal commented Sep 10, 2023 • edited

vkarpov15 commented Sep 18, 2023

lbertoncello commented Jul 12, 2021 •

edited

IslandRhythms commented Jul 12, 2021 •

edited

lbertoncello commented Jul 12, 2021 •

edited

rajathongal commented Sep 10, 2023 •

edited